Ensure form presenter is applied on create/update actions#8238
Merged
Conversation
Now that these are visible on submission when form is invalid, we can update them. If the list only contains a single item them the bottom margin makes it look off. We now use the space-y-* utility to dynamically control the spacing between child elements from the parent. Also adjust the bottom margin on the list to be larger and smaller rounded borders to match.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8238 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 140 140
Lines 4018 4018
=======================================
Hits 3982 3982
Misses 36 36 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug when submitting a form that contains validation errors, the form page presenter wasn't being applied so the default was used. I realized during testing that the
f.semantic_errorsdisplay wasn't having any effect when it should have. With this fix, it now does. This is the same fix as we did for the page title on form submission in #8210 specifically this commit 783992e.This also fixes some styling issues with the form errors list which is what we were testing. If the list only contains a single item then the bottom margin makes the alignment look off. We now use the space-y-* utility to dynamically control the spacing between child elements from the parent.