Some final updates before v4 beta1#8210
Merged
Merged
Conversation
We should have at least a model with validation for form testing without having to make changes. For now we'll update the category model since it's the easiest. Only one case where it was creating the model without any data.
Use an explicit named class name and show adding a data attribute as an example here.
This rule starts to get problematic with links elsewhere that are set to inherit text color in default state (non-dark mode). I noticed this with the table column links. We've already been setting no-underline on any links elsewhere, including table column. This is easier to override per element and will at least give links a default style similar to the previous version which I think others will still want to have in place.
When submitting the form and its re-rendered due to validation errors, then the page title ending up being a generic "Create" vs what it used to be like "New Post". Reviewing the original implementation in v3, the action is normalized regardless of the action so we have to account for create/update here in the when statement to preverse the same behavior.
Tests for page registration which was reusing the index_table class directly to work with an existing expectation but its using table_for which we have our dedicated class name for since its a table component vs just a table.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8210 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 140 140
Lines 4013 4017 +4
=======================================
+ Hits 3977 3981 +4
Misses 36 36 ☔ View full report in Codecov by Sentry. |
javierjulio
added a commit
that referenced
this pull request
Jan 16, 2024
* Apply form page presenter on submit when invalid If the form is invalid, the form page presenter wasn't being applied. Same fix as we did for the page title on form submission in #8210 specifically this commit: 783992e * Update form errors styles Now that these are visible on submission when form is invalid, we can update them. If the list only contains a single item them the bottom margin makes it look off. We now use the space-y-* utility to dynamically control the spacing between child elements from the parent. Also adjust the bottom margin on the list to be larger and smaller rounded borders to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some final updates before our first beta release of v4. This fixes the default anchor style by just setting it as a base style and defining no-underline and default text colors where it was missing. I think this will be best to keep a default link style which I think will be expected and not set it by default with a class which had some conflicts with dark mode styles. This keeps the specificity low.