Skip to content

Backport provide detail in DB statement timeout error for filters#8163

Merged
mgrunberg merged 1 commit into
activeadmin:3-0-stablefrom
mgrunberg:backport-8117
Dec 11, 2023
Merged

Backport provide detail in DB statement timeout error for filters#8163
mgrunberg merged 1 commit into
activeadmin:3-0-stablefrom
mgrunberg:backport-8117

Conversation

@mgrunberg

@mgrunberg mgrunberg commented Dec 10, 2023

Copy link
Copy Markdown
Contributor

Backport #8117


Give more info about db timeout error in filters

When a database timeout error occurs querying the values for a filter, the error message does not give the filter information

…error for filters (activeadmin#8117)

Give more info about db timeout error in filters

When a database timeout error occurs querying the values for
a filter, the error message does not give the filter information
@codecov

codecov Bot commented Dec 10, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (3-0-stable@4ce39bb). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff              @@
##             3-0-stable    #8163   +/-   ##
=============================================
  Coverage              ?   99.18%           
=============================================
  Files                 ?      194           
  Lines                 ?     4934           
  Branches              ?        0           
=============================================
  Hits                  ?     4894           
  Misses                ?       40           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgrunberg mgrunberg merged commit 345e02e into activeadmin:3-0-stable Dec 11, 2023
@mgrunberg mgrunberg deleted the backport-8117 branch December 11, 2023 13:08
@mgrunberg mgrunberg changed the title Backport to 3-0 stable branch provide detail in DB statement timeout error for filters (#8117) Backport provide detail in DB statement timeout error for filters Dec 11, 2023
faizaankhan pushed a commit to bugcrowd/activeadmin that referenced this pull request Dec 28, 2023
…error for filters (activeadmin#8117) (activeadmin#8163)

Give more info about db timeout error in filters

When a database timeout error occurs querying the values for
a filter, the error message does not give the filter information

Co-authored-by: Vicente Correa <vcorrea@buk.cl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants