Provide detail in DB statement timeout error for filters#8117
Merged
javierjulio merged 1 commit intoDec 1, 2023
Conversation
Contributor
|
Thanks for this PR. Any chance to add a spec to cover this use case? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8117 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 182 182
Lines 4721 4722 +1
=======================================
+ Hits 4676 4677 +1
Misses 45 45 ☔ View full report in Codecov by Sentry. |
9e646d8 to
596e7c6
Compare
Contributor
Author
|
@tagliala good idea. Spec ready, thank you! |
javierjulio
reviewed
Nov 26, 2023
0b56391 to
9ab7883
Compare
9ab7883 to
39eebb6
Compare
When a database timeout error occurs querying the values for a filter, the error message does not give the filter information
39eebb6 to
c7951a2
Compare
mgrunberg
pushed a commit
to mgrunberg/activeadmin
that referenced
this pull request
Dec 10, 2023
…error for filters (activeadmin#8117) Give more info about db timeout error in filters When a database timeout error occurs querying the values for a filter, the error message does not give the filter information
faizaankhan
pushed a commit
to bugcrowd/activeadmin
that referenced
this pull request
Dec 28, 2023
…error for filters (activeadmin#8117) (activeadmin#8163) Give more info about db timeout error in filters When a database timeout error occurs querying the values for a filter, the error message does not give the filter information Co-authored-by: Vicente Correa <vcorrea@buk.cl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone! 👋
When a database timeout error occurs querying the values for a sidebar filter, the error message does not report that it is an error in the filters nor does it indicate the specific filter with the error, so I propose this change to give more information to the developer about the error so he can work on it.
Context: using a Rails application in which I use Active Admin, I accessed the view of a resource with many records and after a few seconds I got the error
PG::QueryCanceled: ERROR: canceling statement due to statement timeout, but the error was not querying records for the table, it was querying values for a sidebarSelectInputfilter.