Allow ApplicationController and helpers to reload in development environment#3927
Closed
jvaill wants to merge 1 commit into
Closed
Allow ApplicationController and helpers to reload in development environment#3927jvaill wants to merge 1 commit into
jvaill wants to merge 1 commit into
Conversation
Contributor
|
It seems like there should be a way to allow these files to be reloaded without moving them out of the By the way, last year there was a PR that did something similar, that didn't end up being merged: #2906. |
Author
|
Just quickly brainstorming, off the top of my head I can think of a few other feasible solutions:
If we'd rather not shuffle files around, then looking into the third option might be worth it. |
Member
|
I agree with @seanlinsley, so I'm closing this, but I will copy your ideas over to #697. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #697.
The problem is that
PageControllerand its ancestors (up until::InheritedResources::Base) don't reload by default and thus don't end up inheriting from future changes made toApplicationController. It turns out that autoloading a class withActiveSupport::Autoloaddoes nothing to hook into Rails' reloading mechanism.This PR moves the controllers to
app/controllers/which allows Rails to take over its autoloading and its reloading.A good way to test this is with @timoschilling's minimal test case:
https://github.com/activeadmin/activeadmin_helper_reload_bug
🎉