Move controllers and concerns under app/controllers and app/concerns#2906
Move controllers and concerns under app/controllers and app/concerns#2906a-chernykh wants to merge 1 commit into
Conversation
In order to get files automatically reloaded in Rails, these files should be under `ActiveSupport::Dependencies.autoload_paths` directory. `Rails::Engine` adds `app/controllers` path automatically to `autoload_paths`. Reference: rails/rails#12195 (comment) Closes activeadmin#697
|
@seanlinsley any issues with this PR? |
|
@seanlinsley sorry for being pushy, but I really would love to hear back 😄 This caching problem still bothers me... |
|
I'm not a user of The amount of code moved might be scary, so I'm thinking what if With I've done some poking and prodding and here's what I have: thedarkone@2086cae. Unfortunately I don't really have the time to work further on this, so @andreychernih if you want pick up on the |
|
The idea behind this PR is good, but at the moment we have to many other problems in active admin with the autoloading / code reloading. And there are some problems explicit with this PR:
This is way I'm going to close this, but I will create a issue which address this problem and add them to a 2.0 millstone. |
|
As maintainer I would be open to changes like these to improve the development experience. I’ve had much success with extracting view partials for a v4 release of ActiveAdmin (using TailwindCSS) that now reload on local development of the library. I’d love to have this for the host app. If someone wants to take this on that would be most helpful. |
In order to get files automatically reloaded in Rails, these files should be under
ActiveSupport::Dependencies.autoload_pathsdirectory.Rails::Engineaddsapp/controllerspath automatically toautoload_paths.Reference: rails/rails#12195 (comment)
Closes #697