Fix app helper autoloading in dev and isolate namespace#8180
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8180 +/- ##
==========================================
- Coverage 99.04% 99.04% -0.01%
==========================================
Files 152 152
Lines 4184 4173 -11
==========================================
- Hits 4144 4133 -11
Misses 40 40 ☔ View full report in Codecov by Sentry. |
15d3ad6 to
b4e8be9
Compare
With the base, page and resource controllers migrated to app folder for autoloading and fixing helper bug changes not reloading in the host app, I think this has to be used with `isolate_namespace ActiveAdmin` in the engine file for this to be a safe change. With the namespace isolation in place, I encounter an error though when loading the login form page where the URL helpers don't seem to be accessible from the sessions new template. The admin pages work fine.
Now with isolate_namespace being used, these helpers will fail unless we specify main_app proxy per the Rails Engines guide.
This also changed with the isolate_namespace usage.
b4e8be9 to
ce9cbc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This incorporates the changes from #3927 that when testing locally with the helper bug reproductions it resolves the autoloading issue. I think this has to be used with
isolate_namespace ActiveAdminin the engine file for this to be a safe change. With the namespace isolation in place, I encounter an error though when loading the login form page where the URL helpers don't seem to be accessible from the sessions new template. The admin pages work fine.