Fix wasLastUpdatedBefore to be in days, not hours#8
Merged
damccorm merged 1 commit intoactions:masterfrom Aug 19, 2019
jrbriggs:patch-1
Merged
Fix wasLastUpdatedBefore to be in days, not hours#8damccorm merged 1 commit intoactions:masterfrom jrbriggs:patch-1
damccorm merged 1 commit intoactions:masterfrom
jrbriggs:patch-1
Conversation
The parameters and variables names make it seem like this is the intended behavior.
This was referenced Aug 17, 2019
derrickstolee
approved these changes
Aug 18, 2019
derrickstolee
approved these changes
Aug 18, 2019
derrickstolee
left a comment
There was a problem hiding this comment.
I will chime in that this would match the variable names.
localheinz
reviewed
Aug 18, 2019
|
|
||
| function wasLastUpdatedBefore(issue: Issue, num_days: number): boolean { | ||
| const daysInMillis = 1000 * 60 * 60 * num_days; | ||
| const daysInMillis = 1000 * 60 * 60 * 24 * num_days; |
There was a problem hiding this comment.
Perhaps it makes sense to adjust to
Suggested change
| const daysInMillis = 1000 * 60 * 60 * 24 * num_days; | |
| const daysInMillis = num_days * 24 * 60 * 60 * 1000; |
?
derrickstolee
added a commit
to microsoft/scalar
that referenced
this pull request
Aug 18, 2019
This is to work around a bug in the action where the timespan computation was in hours, not days. I have proposed the fix in actions/stale#8
joschi
added a commit
to dropwizard/dropwizard
that referenced
this pull request
Aug 20, 2019
Issues and PRs will be marked as stale after 90 days and removed if there wasn't any activity 14 days after that. Refs #2884 Refs #2888 Refs actions/stale#8
joschi
added a commit
to dropwizard/dropwizard
that referenced
this pull request
Aug 20, 2019
Issues and PRs will be marked as stale after 90 days and removed if there wasn't any activity 14 days after that. Refs #2884 Refs #2888 Refs actions/stale#8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameters and variables names make it seem like this is the intended behavior.