Merged
Conversation
johnb432
commented
Jan 27, 2024
rautamiekka
reviewed
Jan 27, 2024
Contributor
|
Something that has always frustrated me about vehicle cookoff is how the ammo goes shooting out of the vehicle, sometimes landing 100m+ away from it. A round's propellant burning doesn't actually give it velocity unless it's contained by a barrel, it will just pop out of its casing, and ammo in storage shouldn't be exiting the vehicle at all. |
lambdatiger
reviewed
Jan 28, 2024
Apricot-ale
reviewed
Jan 30, 2024
Member
|
This or #5327 first for review? |
Contributor
Author
Contributor
Author
Contributor
Author
|
This is fully ready to review. |
LinkIsGrim
reviewed
Feb 5, 2024
LinkIsGrim
approved these changes
Apr 4, 2024
Contributor
Author
|
I'll hold off from merging until #9061 is merged. |
johnb432
commented
May 24, 2024
Member
|
@johnb432 merge conflicts |
Contributor
Author
I need to still resolve some stuff, so hold off from merging, I'll handle it. |
Contributor
Author
|
I'm done with the changes. Those changes are:
|
LinkIsGrim
approved these changes
Jun 5, 2024
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
* Cook-off improvements * More changes * Update fnc_getVehicleAmmo.sqf * Better engine fire placement * Update fnc_detonateAmmunition.sqf * Update XEH_postInit.sqf * Update fnc_getVehicleAmmo.sqf * Update events-framework.md * Various improvements * Separate effect handling * Tweaks * Update XEH_postInit.sqf * Prevent double ammo detonation * Fixed objects not being able to cook-off again * Added incendiary rounds as source of box cookoff * Converted enable setting to bool * Fixed brackets * Update fnc_cookOff.sqf * Update CfgEden.hpp * Removed GVAR(enable), added GVAR(enableFire) back * Update initSettings.inc.sqf * Update events-framework.md * Update addons/cookoff/functions/fnc_cookOffEffect.sqf * Restructured, redid API events * Fix effect for JIP, minor optimisations * Removed `cbaSettings_settingChanged` * Renamed variables, tweaked string table entries * Update fire damage acemod#9991 * Capitalize comments again * Fix cookoff for very short durations and fix effect removal being too quick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
(exception are the jet and ring effects, as they only last 20 seconds max).vehicle_damage).GVAR(enable)has been removed.GVAR(enableFire),GVAR(enableAmmoCookoff)&GVAR(enableAmmobox)) that allow to control most aspects thatGVAR(enable)does, making it redundant.QGVAR(enable)on objects will no longer affect ammo detonation, but only fire effects.QGVAR(enableAmmoCookoff)already exists and can be set in the editor, although that's currently not listed in the docs - that has been rectified.GVAR(enableFire)is now the sole setting that handles vehicle cook-off fire. This setting does not handle ammo detonation (handled byGVAR(enableAmmoCookoff)).GVAR(cookoffDuration)for cook-off (fixes Cook off bug - vehicle never explodes, and cook off flame occurs multiple times. #9743).GVAR(probabilityCoef)has been made useful again. It's only used in theadvanced vehicle damagecomponent.GVAR(removeAmmoDuringCookoff)fromvehicle_damageintocookoff.Changed it so that it removes all magazines upon ammunition cook-off.
SP and MP testing has been conducted, but could use some more.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.