But the cook off sounds have been redone for last release, haven't they?

I failed to see that this was for the ammo cook offs

I am currently working to Implement an Object Pooling Solution and LAxemann is not 100% happy with the sounds and may change them a bit.

Pushing back to 3.12.0, would like to see more discussion on this versus old system.

The new variant sounds good, but I do not know how the old one was.

The old.system had no sound modulation on distances so it sounded like the explosion was close even when that was not the case

And no SOS calculation so a rocket explosion sound was by the player at the moment of creation, of the sound object. The new system now have 3 steps for modulation of the sound and also uses a correct sos timing

The old sounds also clipped what created kind of white noice

Pushing this milestone back in favour of getting 3.12.0 out the door, significant changes that require some further review.

Is there any performance impact associated with this? I've always been a little dubious about the whole creating objects for sound addons thing, but never properly looked into it.

we should take the sounds but not the code from this PR.

we should take the sounds but not the code from this PR.

I do not think that that is possible because the sounds are made to change at different distances and playSound3D does not support that at all.
Also, playSound3D creates a Globally Synced Object what is more stress on the network than a CBA Event with data attached.
so when we would switch back to the old code base it would create the same jarring sounds.
playSound3D is just not made for Effect sounds that are meant to reach more than 100m

the new ones sounds way much better is this still WIP?

I wanted to implement this using CBATeam/CBA_A3#1174 which is not finished.

I wanted to implement this using CBATeam/CBA_A3#1174 which is not finished.

@commy2 maybe this PR should be merged and when CBA implementation is ready it can be edited?

But I don't like this implementation.

Anyone wants to do anything with this?

Anyone wants to do anything with this?

I think it would be neat. I need to take a better look at it once I have cleared my backlog.

I went ahead and pushed my suggestions after testing. The sounds might not be loud enough in its current implementation, but that can be easily tweaked via playSound3D.
Further feedback is needed for the above, but for me this is good to go.

In the latest commit I bumped the volume from 1 to 2.
Feedback on the volume in general is needed.