[WIP] SyliusReviewBundle by Zales0123 · Pull Request #2 · Zales0123/Sylius

Zales0123 · 2015-08-19T08:07:24Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets
License	MIT
Doc PR	in progress

Initial implementation of SyliusReviewBundle, which allows to easily manage review system. It's based on Sylius#431. "Reviewable" and "Reviewer" classes can be configured under sylius_review tag:

sylius_review:
    classes:
        product:
            subject: Sylius\Component\Core\Model\Product
            review:
                model: Sylius\Component\Product\Model\ProductReview
                form:
                    default: Sylius\Bundle\ProductBundle\Form\Type\ProductReviewType
                    admin: Sylius\Bundle\CoreBundle\Form\Type\ProductReviewAdminType
            reviewer:
                model: Sylius\Component\Core\Model\Customer

Reviews can be written by customers and guests on the product page. Newly created review has state new and can be confirmed or rejected by administrator. After confirming, it's product has average rating calculated. There are 3 possible behaviors while review creation:

if customer is logged in, it's automatically assigned as review author
if customer is not logged in, email must be provided and new customer is created based on it
if provided email is already used, "please, log in" message is displayed

Reviews can be also created in administration panel, with choosing product and author.

There are still some things that have to be changed to make it working perfectly:

change ProductReviewType to use CustomerGuestType or some similar UserBundle form type: for now there is custom transformer and listener, cause existing CustomerGuestType doesn't exactly fit ReviewBundle needs - they would probably removed after fixing this point
consider how review author should be displayed on reviews list:
- john.doe@example.com
- John Doe
- John D.
think about CustomerDeleteListener: currently every review of deleted customer is deleted as well, but I think there should have author field changed to "deleted user" or sth like this - I would appreciate any ideas about implementation
work on translations, cause I'm sure not everything is translated for now

Some ideas for future improvements:

send notification email to review author after accepting/rejecting his review
add possibility to send reason, why review was rejected
add proper info label to review if authored by user, that have already bought reviewed subject

I will be thankful for some review, cause I'm pretty sure there are some part when my code can be improved ;)

pamil · 2015-08-24T10:12:03Z

features/frontend/products.feature

There should be space instead of _, it's business scenario :)

…ces-in-taxation [Taxation] Remove fluent interfaces

…es-remove [Promotion] Remove all fluent interfaces

[Product] Removed fluent interfaces

…e-context [Core] Delete commented line in CoreContext

…k-context [Core] Delete commented code in HookContext

Split bundle to bundle and component. Removed unnecessary classes, due to logic changes. General code refactoring.

Calculate average rating on review confirmation, not creation.

Split configurations into Review-, Product- and CoreBundle parts

Also some general and CS fixes.

Also some changes/fixes in templates and crucial changes in review creation.

[Behat] Fix pricing-related validation message assertions

Uncaught Symfony\Component\Debug\Exception\ContextErrorException: Warning: Cannot bind closure to scope of internal class ReflectionProperty in /Users/pamil/Projects/Sylius/Sylius/var/cache/test/appTestProjectContainer.php:28784 Stack trace: #0 [internal function]: SyliusBundleChannelBundleDoctrineORMChannelRepository_000000004a4ae55b000000001fee2e9bc41b18016a7f6458d1a51d748b49311b->__set('_entityName', NULL) #1 /Users/pamil/Projects/Sylius/Sylius/app/TestAppKernel.php(72): ReflectionProperty->setValue(Object(SyliusBundleChannelBundleDoctrineORMChannelRepository_000000004a4ae55b000000001fee2e9bc41b18016a7f6458d1a51d748b49311b), NULL) #2 /Users/pamil/Projects/Sylius/Sylius/app/TestAppKernel.php(41): TestAppKernel->cleanupContainer(Object(appTestProjectContainer)) #3 /Users/pamil/Projects/Sylius/Sylius/vendor/lakion/api-test-case/src/ApiTestCase.php(85): TestAppKernel->shutdown() #4 /Users/pamil/Projects/Sylius/Sylius/vendor/phpunit/phpunit/src/Framework/TestSuite.php(727): Lakion\ApiTestCase\ApiTestCase::ensur in /Users/pamil/Projects/Sylius/Sylius/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php on line 99

- desc #1 - desc #2

This PR was merged into the 1.7 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Should resolve: ```bash PHP Fatal error: Uncaught Psalm\Exception\TypeParseTreeException: Unterminated bracket in /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Type/ParseTree.php:571 Stack trace: #0 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Type.php(171): Psalm\Internal\Type\ParseTree::createFromTokens(Array) #1 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2668): Psalm\Type::parseTokens(Array) #2 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2207): Psalm\Internal\Visitor\ReflectorVisitor->getAssertionParts('array<array-key...', Object(PhpParser\Node\Stmt\Function_)) #3 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(323): Psalm\Internal\Visitor\ReflectorVisitor->registerFunctionLike(Object(PhpParser\Node\Stmt\Function_)) #4 /home/travis/build/Sylius/Sylius/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(200): Psalm\Internal\Visitor\Reflect in /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Type/ParseTree.php on line 571 Fatal error: Uncaught Psalm\Exception\TypeParseTreeException: Unterminated bracket in /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Type/ParseTree.php:571 Stack trace: #0 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Type.php(171): Psalm\Internal\Type\ParseTree::createFromTokens(Array) #1 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2668): Psalm\Type::parseTokens(Array) #2 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(2207): Psalm\Internal\Visitor\ReflectorVisitor->getAssertionParts('array<array-key...', Object(PhpParser\Node\Stmt\Function_)) #3 /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Visitor/ReflectorVisitor.php(323): Psalm\Internal\Visitor\ReflectorVisitor->registerFunctionLike(Object(PhpParser\Node\Stmt\Function_)) #4 /home/travis/build/Sylius/Sylius/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(200): Psalm\Internal\Visitor\Reflect in /home/travis/build/Sylius/Sylius/vendor/vimeo/psalm/src/Psalm/Internal/Type/ParseTree.php on line 571 ``` Ref. https://travis-ci.org/github/Sylius/Sylius/jobs/682877325 Ref. amphp/amp#314  Commits ------- f6819a2 [Maintenance] Upgrade psalm version

Zales0123 force-pushed the sylius-review-bundle branch from 5b2574c to 1c32321 Compare August 21, 2015 18:45

pamil reviewed Aug 24, 2015
View reviewed changes

features/frontend/products.feature Outdated

Copy link
Copy Markdown

pamil Aug 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be space instead of _, it's business scenario :)

michalmarcinkowski added 4 commits September 23, 2015 15:57

Merge pull request Sylius#3313 from HerbMat/remove-all-fluent-interfa…

5ffed47

…ces-in-taxation [Taxation] Remove fluent interfaces

Merge pull request Sylius#3327 from tuka217/promotion-fluent-interfac…

b184d96

…es-remove [Promotion] Remove all fluent interfaces

Merge pull request Sylius#3328 from Arminek/SYLIUS-82-product-component

8fc6a23

[Product] Removed fluent interfaces

Merge pull request Sylius#3322 from HerbMat/delete-unused-line-in-cor…

6a4144f

…e-context [Core] Delete commented line in CoreContext

Zales0123 force-pushed the sylius-review-bundle branch from 43c464a to 49e9600 Compare September 23, 2015 14:22

michalmarcinkowski and others added 16 commits September 23, 2015 16:22

Merge pull request Sylius#3325 from HerbMat/delete-unused-code-in-hoo…

dbc11b5

…k-context [Core] Delete commented code in HookContext

[Review] SyliusReviewBundle initialization

0b7d169

[Review] ReviewBundle refactoring

27996fa

Split bundle to bundle and component. Removed unnecessary classes, due to logic changes. General code refactoring.

[Review] Basic review logic finished, with added validation

3cb86c4

[Review] Behat scenarios and average rating feature implemented

14cd3ca

[Review] State machine for review implemented

a6db770

Calculate average rating on review confirmation, not creation.

[Review] General fixes and improvements

c9ef5a9

[Review] General fixes and improvements

ec4a2d1

[Review] Make reviews more generic

7b9ab1a

Split configurations into Review-, Product- and CoreBundle parts

[Review] Split ProductReviewAdminType to Product- and CoreBundle part

78a8829

[Review] Implemented ReviewDeleteListener

e91de1c

Also some general and CS fixes.

[Review] Change ReviewAuthorInterface to ReviewerInterface

9a3c1f6

[Review] Added default Reviewer class

f604fc5

[Review] Added listeners on Product and Customer deletion

34c499d

[Review] PR review changes vol.1

2c1f6d5

[Review] Added dynamic tags on ReviewDeleteListener

0e26b07

Also some changes/fixes in templates and crucial changes in review creation.

Zales0123 force-pushed the sylius-review-bundle branch from 49e9600 to 0e26b07 Compare September 23, 2015 14:28

Zales0123 closed this Sep 29, 2015

Zales0123 pushed a commit that referenced this pull request Nov 20, 2015

[Travis] Combined suites #1 and #2 into one

39a8cca

Zales0123 added a commit that referenced this pull request Feb 7, 2017

Final PR review fixes #2

b6dece4

Zales0123 added a commit that referenced this pull request Feb 7, 2017

Final PR review fixes #2

e7d45ec

Zales0123 pushed a commit that referenced this pull request Mar 9, 2017

Merge pull request #2 from pamil/pull-request/7087

3d7771b

[Behat] Fix pricing-related validation message assertions

Zales0123 added a commit that referenced this pull request Mar 6, 2019

Git basics

a0aa06c

- desc #1 - desc #2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] SyliusReviewBundle#2

[WIP] SyliusReviewBundle#2
Zales0123 wants to merge 40 commits intomasterfrom
sylius-review-bundle

Zales0123 commented Aug 19, 2015

Uh oh!

pamil Aug 24, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

Zales0123 commented Aug 19, 2015

Uh oh!

pamil Aug 24, 2015

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants