[Promotion] Remove all fluent interfaces#3327
Merged
michalmarcinkowski merged 1 commit intoSylius:masterfrom Sep 23, 2015
Merged
[Promotion] Remove all fluent interfaces#3327michalmarcinkowski merged 1 commit intoSylius:masterfrom
michalmarcinkowski merged 1 commit intoSylius:masterfrom
Conversation
Contributor
tuka217
commented
Sep 22, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed tickets | no |
| License | MIT |
| Doc PR | no |
Contributor
There was a problem hiding this comment.
This should be removed as rule must be assigned to promotion.
Contributor
There was a problem hiding this comment.
These changes are not related to this PR and that change should be discussed separately, same as all below.
114da0f to
dc6e86c
Compare
michalmarcinkowski
added a commit
that referenced
this pull request
Sep 23, 2015
[Promotion] Remove all fluent interfaces
Contributor
|
Thank you Ania! 👍 |
Contributor
|
Tried to figure out why fluent interfaces were removed. What did I miss? They only are allowed for builders now? http://docs.sylius.org/en/latest/bundles/SyliusProductBundle/product_builder.html |
Contributor
|
@rvanlaak I don't feel to be an authority, so I will just link this article: Fluent Interfaces are Evil. |
Contributor
|
That was a really nice read @lchrusciel , thanks! 👍 I'd conclude that builders because of their nature should be the only ones to use fluent interfaces. |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…es-remove [Promotion] Remove all fluent interfaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.