Check wpseo_use_page_analysis before calculate#7
Closed
sc0ttkclark wants to merge 4 commits intoYoast:masterfrom
sc0ttkclark:patch-1
Closed
Check wpseo_use_page_analysis before calculate#7sc0ttkclark wants to merge 4 commits intoYoast:masterfrom sc0ttkclark:patch-1
sc0ttkclark wants to merge 4 commits intoYoast:masterfrom
sc0ttkclark:patch-1
Conversation
When saving, PHP fatals out when calculate_results tries to call 'Yoast_TextStatistics' but it doesn't exist, because wpseo_use_page_analysis has disabled it. This extra check avoids running the page analysis related functionality during save / etc, which is where it fatals out.
Contributor
|
Could you check this against trunk? We just updated :-) |
Updates for latest WPSEO
Author
|
Updated |
2 tasks
2 tasks
Closed
2 tasks
2 tasks
14 tasks
4 tasks
9 tasks
6 tasks
Closed
11 tasks
9 tasks
5 tasks
9 tasks
4 tasks
9 tasks
hansjovis
pushed a commit
that referenced
this pull request
Nov 21, 2022
Improve layout improvements
hansjovis
pushed a commit
that referenced
this pull request
Nov 21, 2022
Added the setting up integration tests docs
7 tasks
11 tasks
6 tasks
2 tasks
2 tasks
2 tasks
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When saving, PHP fatals out when calculate_results tries to call 'Yoast_TextStatistics' but it doesn't exist, because wpseo_use_page_analysis has disabled it.
This extra check avoids running the page analysis related functionality during save / etc, which is where it fatals out.