Just changed some code for the diacritics support in /js/wp-seo-metabox.js#2
Closed
gbili wants to merge 7 commits intoYoast:masterfrom
Closed
Just changed some code for the diacritics support in /js/wp-seo-metabox.js#2gbili wants to merge 7 commits intoYoast:masterfrom
gbili wants to merge 7 commits intoYoast:masterfrom
Conversation
added 7 commits
December 8, 2012 22:32
… removed from slug
…repo was on GitHub to merge from jdevalk version is from 1 month ago)
…t's the diacritics equivalent...
or not. The update makes wp-seo match all occurences of the keyword inside the content. It then informs the user what type of matches it found. Case scenario : keyword has no diacritics, but the content (anywhere in the content: url, title, text, etc.) does have 2 keywrods with diacritics and 3 without. The new update outputs this to the user: <span title="it you see D.E. it means Diacritics Equivalent (Intl chars)" class="good"> Yes (3), D.E (2) </span>
… informs the users about it.
Author
There was a problem hiding this comment.
moved ptest() function below removeLowerCaseDiacritics()
Contributor
barrykooij
added a commit
that referenced
this pull request
Jan 29, 2014
Contributor
|
This PR has been open for a very long time and our codebase has changed a lot since this PR was made, this PR is very messy and it appears that half of this PR is already added to current master. For these reasons it has become almost impossible to merge this PR into master. |
moorscode
pushed a commit
that referenced
this pull request
Mar 7, 2016
moorscode
pushed a commit
that referenced
this pull request
Apr 13, 2016
default: false to empty string Spacing in JS
8 tasks
leonidasmi
added a commit
that referenced
this pull request
May 26, 2022
hansjovis
pushed a commit
that referenced
this pull request
Nov 21, 2022
Moved docusaurus outside website directory
7 tasks
nickdavis
added a commit
to nickdavis/wordpress-seo
that referenced
this pull request
Apr 1, 2023
Fixes Yoast\WP\Lib\Dependency_Injection\Container_Registry::register(): Argument Yoast#2 ($container) must be of type YoastSEO_Vendor\Symfony\Component\DependencyInjection\ContainerInterface, null given, called in /wp-content/plugins/wordpress-seo/lib/abstract-main.php on line 34 Discussed with Yoast Support via email and referencing issue number IM-296. As requested, this is a PR which solves this issue which I'm consistently seeing when installing WordPress SEO Premium and Yoast SEO Local via composer (with WordPress SEO standard, installed as a dependency) for a long time, across multiple versions. Full error message / call stack at the following link: https://share.cleanshot.com/3TNnjlHH
16 tasks
11 tasks
11 tasks
11 tasks
6 tasks
2 tasks
2 tasks
2 tasks
11 tasks
11 tasks
Closed
4 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is more clear now whether the matched keyword is the real keyword or the diacritical counterpart.
It says 52 files changed, but really I only would like you to merge the wp-seo-metabox.js if that is ok with you thanks.