Added check for facebook_image post meta as primary Facebook thumbnail#5
Closed
ddn wants to merge 1 commit intoYoast:masterfrom
ddn:master
Closed
Added check for facebook_image post meta as primary Facebook thumbnail#5ddn wants to merge 1 commit intoYoast:masterfrom ddn:master
ddn wants to merge 1 commit intoYoast:masterfrom
ddn:master
Conversation
Contributor
|
Hi @ddn, thanks for this! We're going to be far more active here on Github so we're actually looking properly into all these requests now. To be honest, we'll probably never add a "technical" fix like this. I want to do something like this but it'd require an actual interface in the plugin, where in the social meta box people could select an image... If you want to build a patch for that, that'd be most welcome :) if not, do let me know and I'll write up the issue and I'll assign it to a dev. |
Contributor
|
I'm not expecting a new PR on this here, so I've created an issue #784. |
stodorovic
pushed a commit
to stodorovic/wordpress-seo
that referenced
this pull request
Mar 10, 2016
2 tasks
2 tasks
2 tasks
Closed
2 tasks
1 task
2 tasks
2 tasks
11 tasks
8 tasks
9 tasks
5 tasks
9 tasks
4 tasks
omarreiss
pushed a commit
that referenced
this pull request
Feb 24, 2021
uses higher level function in yoast frontend class
10 tasks
9 tasks
hansjovis
pushed a commit
that referenced
this pull request
Nov 21, 2022
Adds missing Standards documentation
7 tasks
11 tasks
11 tasks
6 tasks
2 tasks
2 tasks
2 tasks
11 tasks
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some sites, maintainers may desire to retain more control of what image is used for Facebook OpenGraph thumbnails.
My site, for example, uses a wide landscape format for site images. When Facebook pulls these images, it often crops them in an unfavorable way. I prefer to manually select the image I want promoted for the site content.
This change checks for a facebook_image post_meta value, and if it exists, returns it as the SOLE thumbnail for opengraph. Removing the return true would allow it to be returned as one of many if there are other thumbnails available.
Ideally, this would probably be an option that can be chosen in the setting.