Twenty Twenty-One: Support custom colors in the template editor#1626
Draft
carolinan wants to merge 1 commit intoWordPress:masterfrom
Draft
Twenty Twenty-One: Support custom colors in the template editor#1626carolinan wants to merge 1 commit intoWordPress:masterfrom
carolinan wants to merge 1 commit intoWordPress:masterfrom
Conversation
Support custom colors in the the template editor using block_editor_settings_all. Add the is-dark-theme CSS class to the body of the template editor iframe. Trac: https://core.trac.wordpress.org/ticket/53564
kjellr
added a commit
to kjellr/wordpress-develop
that referenced
this pull request
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports custom colors in the template editor using
block_editor_settings_all.Adds the
is-dark-themeCSS class to the body of the template editor iframe.This fixes an issue where the background color selected in the customizer did not display in the template editor,
with or without dark mode enabled.
Relies on #1455
The colors will not display correctly without 1455.
What is left to do:
Trac ticket: https://core.trac.wordpress.org/ticket/53564
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.