Twenty Twenty-One: Add block template support, including a default template#1455
Open
kjellr wants to merge 22 commits intoWordPress:masterfrom
Open
Twenty Twenty-One: Add block template support, including a default template#1455kjellr wants to merge 22 commits intoWordPress:masterfrom
kjellr wants to merge 22 commits intoWordPress:masterfrom
Conversation
kjellr
commented
Jul 1, 2021
src/wp-content/themes/twentytwentyone/assets/sass/05-blocks/columns/_style.scss
Outdated
Show resolved
Hide resolved
…o-twenty-twenty-one
| <!-- /wp:group --> | ||
|
|
||
| <!-- wp:group {"align":"full","tagName":"main"} --> | ||
| <div class="wp-block-group alignfull entry-header"><!-- wp:group {"align":"wide","layout":{"inherit":true}} --> |
There was a problem hiding this comment.
I think the entry-header class should go on the header tag right above. This is adding a weird padding and border at the bottom of the page
Author
There was a problem hiding this comment.
Great catch, thank you! I've taken a different approach to this in 3bbcd26, and it should be working better now. 👍
as well as bottom spacing for the default template.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds block template support to Twenty Twenty-One, and also provides a default block template, as per the instructions here:
https://make.wordpress.org/core/2021/06/16/introducing-the-template-editor-in-wordpress-5-8/
The default template includes a simplified approximation of the default page layout, minus things like navigation and a footer (which requires translatable text — something not yet possible in block templates). This was pulled from TT1 Blocks, but simplified down a little bit.
Note: The theme stylesheet is not loaded in the template editor. A warning is thrown about this, but I'm not sure what to make of it since Twenty Twenty-One does enqueue the stylesheet properly via
add_editor_style().GIF:
Trac ticket: https://core.trac.wordpress.org/ticket/53564
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.