Added discord in social links.#68848
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Gulamdastgir-Momin! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
The code looks good overall, but the icon itself could be improved a bit. The current icon is slightly off-center:
Additionally, it would be good to make the path exactly 20px wide, like the other icons.
I've tried adjusting the icon, but it didn't work. I'd be happy if someone from the @WordPress/gutenberg-design could provide the icon 🙏
9217a1c to
10765b5
Compare
|
I wonder why these unit test cases are failing 🤔 |
|
The reason is that the following two files have been deleted in this PR. These two files need to be restored:
|
10765b5 to
fb20b00
Compare
t-hamano
left a comment
There was a problem hiding this comment.
LGTM!
@WordPress/gutenberg-design Maybe I'm being a bit overly sensitive, but if there's room for improvement in the icon and you can provide an SVG, I'd be happy to follow up. For now, it looks good compared to the other icons, so I'd like to merge it.
|
Thanks, @t-hamano, for your approval and guidance. Really appreciated! |
* Added discord in social links. * Remove separator color fixtures. * Restore separator color fixture. * Added svg version. Co-authored-by: Gulamdastgir-Momin <gulamdastgir04@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mrfoxtalbot <mrfoxtalbot@git.wordpress.org> Co-authored-by: donalirl <donalirl@git.wordpress.org>
* Added discord in social links. * Remove separator color fixtures. * Restore separator color fixture. * Added svg version. Co-authored-by: Gulamdastgir-Momin <gulamdastgir04@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mrfoxtalbot <mrfoxtalbot@git.wordpress.org> Co-authored-by: donalirl <donalirl@git.wordpress.org>
What?
FIxes: #35487
Adds Social Link variation for Discord.
How?
Added discord.js to block-library/icons to add the official svg. Added a line for exporting the icon. Added Discord to the list of services so it will use the correct block variation.
PS: This PR was closed, so I created a new PR.