Skip to content

Adding Discord Social Link#60865

Closed
JoshQuake wants to merge 7 commits intoWordPress:trunkfrom
JoshQuake:add/discord-social-link
Closed

Adding Discord Social Link#60865
JoshQuake wants to merge 7 commits intoWordPress:trunkfrom
JoshQuake:add/discord-social-link

Conversation

@JoshQuake
Copy link
Copy Markdown

@JoshQuake JoshQuake commented Apr 18, 2024

What?

Adds Social Link variation for Discord.

Why?

I can't figure out how to add it through a separate plugin so here I am lol.

How?

Added discord.js to block-library/icons to add the official svg. Added a line for exporting the icon. Added Discord to the list of services so it will use the correct block variation.

Testing Instructions

  1. Edit page.
  2. Add Social Icons widget.
  3. Add Discord Social Icon.

Testing Instructions for Keyboard

Screenshots or screencast

image

@JoshQuake JoshQuake requested a review from ajitbohra as a code owner April 18, 2024 13:25
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 18, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: JoshQuake <joshquake@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 18, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 18, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @JoshQuake! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Block] Social Affects the Social Block - used to display Social Media accounts label Apr 18, 2024
@JoshQuake
Update index.php
0ece642 
Fixed spacing between 'discord' and => in services array
@JoshQuake
Update discord.js
0278b59 
path > Path
fixed indentation
@JoshQuake
Update discord.js
71a2bda 
Prettier error fix????
@JoshQuake
Copy link
Copy Markdown
Author

JoshQuake commented Apr 20, 2024

All checks passed now. Woohoo!

@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Apr 23, 2024

Just connecting the pull request to this open issue: #35487

@carolinan carolinan added the [Type] Enhancement A suggestion for improvement. label Apr 23, 2024
@t-hamano t-hamano self-requested a review September 9, 2024 14:14
t-hamano
t-hamano reviewed Sep 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late attention to this PR, @JoshQuake.

If you have time to work on this PR, could you check the following points to move this PR forward?

  • It would be good to unify viewBox to 0 0 24 24, like the other icons.
  • From the guideline, the primary color of this brand seems to be #5865F2. It would be good to add color to this file and this file.
  • We need to do the following steps to generate a fixture file:
    • Create a core__social-link-discord.html file in test/integration/fixtures/blocks/
    • Write HTML there. Use the other HTML as a reference.
    • Run fixtures:regenerate locally. The following files will be automatically generated:
      • core__social-link-discord.json
      • core__social-link-discord.parsed.json
      • core__social-link-discord.serialized.html
    • Commit and push the changes

If you have any questions, please feel free to ask 👍

@JoshQuake
Copy link
Copy Markdown
Author

JoshQuake commented Sep 9, 2024

No problem @t-hamano, I will make the necessary changes over the weekend.

This was referenced Dec 24, 2024
Closed
Closed
@JoshQuake JoshQuake closed this Jan 15, 2025
@JoshQuake JoshQuake deleted the add/discord-social-link branch January 15, 2025 02:32
@Gulamdastgir-Momin
Copy link
Copy Markdown
Contributor

Gulamdastgir-Momin commented Jan 23, 2025

Hey @Mamaduka, @t-hamano,

As this branch is closed can we reopen #68242

Let me know what you think.

@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Jan 23, 2025

@Gulamdastgir-Momin, I thin same feedback can be applied to your branch.

Rebase your local branch on top of the latest trunk, apply feedback, and it should be good to re-open.

@Gulamdastgir-Momin
Copy link
Copy Markdown
Contributor

Gulamdastgir-Momin commented Jan 23, 2025

Thanks @Mamaduka

Working on it!

@Gulamdastgir-Momin Gulamdastgir-Momin mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano left review comments

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

No one assigned

Labels

[Block] Social Affects the Social Block - used to display Social Media accounts First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JoshQuake @carolinan @Gulamdastgir-Momin @Mamaduka @t-hamano @skorasaurus