Skip to content

Add dropdown menu props to ToolsPanel component#68019

Merged
fabiankaegy merged 9 commits into
WordPress:trunkfrom
im3dabasia:try/refactor-add-dropdown-menu-props
Dec 17, 2024
Merged

Add dropdown menu props to ToolsPanel component#68019
fabiankaegy merged 9 commits into
WordPress:trunkfrom
im3dabasia:try/refactor-add-dropdown-menu-props

Conversation

@im3dabasia

@im3dabasia im3dabasia commented Dec 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What?

Enhances the block's ToolsPanel by adding support for dropdown menu functionality through the useToolsPanelDropdownMenuProps hook.

Progress

  1. Button : In this PR
  2. Table : In this PR
  3. Columns : In this PR
  4. Column : In this PR
  5. Archives : Archive: Add dropdown menu props to ToolsPanel component  #68010
  6. Date : Date Block: Add dropdown menu props to ToolsPanel component #68018
  7. Tag Cloud : In this PR
  8. Site Title : Site Title Block: Add dropdown menu props to ToolsPanel component #68017
  9. Excerpt : In this PR
  10. Social Icon : In this PR
  11. Details : In this PR
  12. Social icons : In this PR
  13. Query Page Numbers
  14. Navigation Submenu : Navigation Submenu Block: Add dropdown menu props to ToolsPanel component #68015
  15. Page List : Page List Block: Add dropdown menu props to ToolsPanel component #68012
  16. Featured image: Featured Image Block: Refactor setting panel #67456
  17. Login/Logout : Login/Logout: Add dropdown menu props to ToolsPanel component #68009
  18. Gallery : Not merged
  19. Archive Title : Not merged
  20. Search Block : Not merged
  21. Latest Posts : Not merged
  22. More : Add Tools Panel dropdown menu props to More block #68039
  23. Navigation item : Not merged
  24. Next Post : Not merged
  25. Author : Not merged
  26. Spacer : Not merged
  27. Table of Contents : Not merged
  28. Term List : Not merged
  29. Latest Comments : Not merged
  30. Site Logo (Media) : Not merged
  31. Avatar : Not merged
  32. Author Name : Not merged
  33. Read More : Not merged
  34. Query Pagination : Query Pagination: Refactor settings panel to use ToolsPanel #67914
  35. Query Loop: Not merged
  36. Navigation (Display): Not merged

Screenshots or screencast

Button

Before After
image Screenshot 2024-12-16 at 2 13 11 PM

Table

Before After
image image

Columns

Before After
image image

Column

Before After
image image

Tag Cloud

Before After
image image

Excerpt

Before After
image image

Social Icon

Before After
image image

Details

Before After
image image

Social Icons

Before After
image image

@im3dabasia

im3dabasia commented Dec 16, 2024

Copy link
Copy Markdown
Contributor Author

Hi @fabiankaegy,

As discussed in link I have opened a draft pull request to add dropdown menu properties for all instances that previously did not have dropdown menu props. For visibility, I will also mention this pull request in the main issue #67813.

@im3dabasia im3dabasia mentioned this pull request Dec 16, 2024
Closed
@Infinite-Null Infinite-Null mentioned this pull request Dec 17, 2024
Merged
@im3dabasia im3dabasia marked this pull request as ready for review December 17, 2024 10:45
@github-actions

github-actions Bot commented Dec 17, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

fabiankaegy
fabiankaegy approved these changes Dec 17, 2024
View reviewed changes

@fabiankaegy fabiankaegy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as intended :) Thanks so much for the follow up! 🚀

@fabiankaegy fabiankaegy added the [Type] Enhancement A suggestion for improvement. label Dec 17, 2024
@fabiankaegy fabiankaegy merged commit 0fdd0a6 into WordPress:trunk Dec 17, 2024
@github-actions github-actions Bot added this to the Gutenberg 20.0 milestone Dec 17, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
@im3dabasia @fabiankaegy @yogeshbhutkar
Ensure all instances of the ToolsPanel uses the useToolsPanelDropdown…
46904cd 
…MenuProps hook for placement (WordPress#68019)

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
@im3dabasia @fabiankaegy @yogeshbhutkar
Ensure all instances of the ToolsPanel uses the useToolsPanelDropdown…
57a642b 
…MenuProps hook for placement (WordPress#68019)

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
@talldan talldan mentioned this pull request Dec 20, 2024
Closed
@Mamaduka Mamaduka added the [Package] Block library /packages/block-library label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabiankaegy fabiankaegy fabiankaegy approved these changes
@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

No one assigned

Labels

[Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 20.0

Development

Successfully merging this pull request may close these issues.

3 participants

@im3dabasia @fabiankaegy @Mamaduka