Skip to content

Page List Block: Add dropdown menu props to ToolsPanel component#68012

Merged
fabiankaegy merged 1 commit into
WordPress:trunkfrom
im3dabasia:try/refactor-dropdown-pagelist-block
Dec 16, 2024
Merged

Page List Block: Add dropdown menu props to ToolsPanel component#68012
fabiankaegy merged 1 commit into
WordPress:trunkfrom
im3dabasia:try/refactor-dropdown-pagelist-block

Conversation

@im3dabasia

@im3dabasia im3dabasia commented Dec 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Follow up of: #67903

What?

Enhances the Page List block's ToolsPanel by adding support for dropdown menu functionality through the useToolsPanelDropdownMenuProps hook.

Screenshots or screencast

Before After
Screenshot 2024-12-16 at 1 19 05 PM Screenshot 2024-12-16 at 1 19 34 PM

@github-actions

github-actions Bot commented Dec 16, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia

im3dabasia commented Dec 16, 2024

Copy link
Copy Markdown
Contributor Author

Hey @fabiankaegy,
This PR is a follow-up to add dropdown menu props to the ToolsPanel component of the Page List block. The initial changes have already been merged.

I have followed #67813 (comment)

@fabiankaegy fabiankaegy added [Block] Page List Affects the Page List Block [Type] Enhancement A suggestion for improvement. labels Dec 16, 2024
fabiankaegy
fabiankaegy approved these changes Dec 16, 2024
View reviewed changes

@fabiankaegy fabiankaegy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up :)

@fabiankaegy fabiankaegy merged commit d02331c into WordPress:trunk Dec 16, 2024
@github-actions github-actions Bot added this to the Gutenberg 20.0 milestone Dec 16, 2024
@im3dabasia im3dabasia mentioned this pull request Dec 16, 2024
Merged
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
@im3dabasia @fabiankaegy @yogeshbhutkar
Page List Block: Add dropdown menu props to ToolsPanel component (Wor…
25806ab 
…dPress#68012)

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
@im3dabasia @fabiankaegy @yogeshbhutkar
Page List Block: Add dropdown menu props to ToolsPanel component (Wor…
3da2e79 
…dPress#68012)

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabiankaegy fabiankaegy fabiankaegy approved these changes
@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

No one assigned

Labels

[Block] Page List Affects the Page List Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 20.0

Development

Successfully merging this pull request may close these issues.

2 participants

@im3dabasia @fabiankaegy