Interactivity API: Backport fixes from Core#59903
Merged
cbravobernal merged 6 commits intotrunkfrom Mar 15, 2024
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SantosGuillamot
approved these changes
Mar 15, 2024
Contributor
SantosGuillamot
left a comment
There was a problem hiding this comment.
LGTM! Thanks for taking care of that 🙂
sirreal
approved these changes
Mar 15, 2024
Member
sirreal
left a comment
There was a problem hiding this comment.
I reviewed these ports and the changes look correct. Thanks!
Comment on lines
+605
to
+606
| false !== $result || | ||
| ( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) |
Member
There was a problem hiding this comment.
Suggested change
| false !== $result || | |
| ( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) | |
| false !== $result || | |
| ( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) |
Comment on lines
+616
to
+617
| is_bool( $result ) && | ||
| ( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) |
Member
There was a problem hiding this comment.
Suggested change
| is_bool( $result ) && | |
| ( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) | |
| is_bool( $result ) && | |
| ( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] ) |
Contributor
Author
|
@sirreal I'm removing the backport label as is used to indicate that the backport is needed, not done. 😄 |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Add mode to directive processing * Add WordPress#59886 wp-develop fix * Add WordPress#6251 fix * Fix linter * Include WordPress#6261 wp-develop * Fix spacing Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Backports fixes done in Core to the Gutenberg compat folder: