Only process directives when applicable#6251
Only process directives when applicable#6251joemcgill wants to merge 3 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
left a comment
There was a problem hiding this comment.
It looks good as a quick fix. We should take a closer look at more optimizations in the WP 6.6 cycle. The change included should relatively good impact, as it skips processing HTML chunks that don't have any directives.
This is a modified PR based on @gziolo's initial approach in this Slack thread.
The main change from his original proposal is to use
str_contains()instead ofstr_pos()given that we have a polyfill for this in Core now. This reduces calls towp_interactivity_process_directives()on the Twenty Twenty-four homepage from 9 to 1 along with memory consumption related to theWP_HTML_Tag_Processor.Trac ticket: https://core.trac.wordpress.org/ticket/60749
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.