Paste: fix MS Word list paste#55127
Merged
tellthemachines merged 3 commits intotrunkfrom Oct 10, 2023
Merged
Conversation
|
Size Change: +58 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7bb8955. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6432419425
|
jorgefilipecosta
approved these changes
Oct 9, 2023
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
I pasted the html provided on the issue on the trunk and verified the list got removed in this branch the issue is fixed 👍 The code also looks good.
41d8f6f to
690cb02
Compare
mikachan
pushed a commit
that referenced
this pull request
Oct 10, 2023
* Paste: fix MS Word list paste * Match mso-list:Ignore * Fix inline paste
Member
|
I just cherry-picked this PR to the 6.4-beta3-2 branch to get it included in the next release: d505480 |
karmatosed
pushed a commit
that referenced
this pull request
Oct 10, 2023
* Site Editor Styles Screen: Fix dancing styles previews (#55183) * Pulling across changes from WordPress/wordpress-develop#5441 (#55181) Removed var * Add `aria-label` attribute to navigation block only when it is open (#54816) * Add `aria-label` only when is open * Remove unnecessary `label` property in edit * Escape translation * Move navigation context to `wp_json_encode` * Add `wp_json_encode` flags * Paste: fix MS Word list paste (#55127) * Paste: fix MS Word list paste * Match mso-list:Ignore * Fix inline paste * Fix scrollbars on pattern transforms (#55069) * Fix scrollbars on pattern transforms * Fix single pattern previews * Improve classname semantics * Remove modal title * Reset styles on window resize (#55077) Co-authored-by: Ricardo Artemio Morales <ric.morales22@gmail.com> --------- Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Mario Santos <34552881+SantosGuillamot@users.noreply.github.com> Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Ricardo Artemio Morales <ric.morales22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #46832.
Why?
The markup that MS Word gives us has changed. We're accidentally deleting the list text because previously the first span was the list number/bullet.
How?
Look for the
mso-list:Ignoreelement.Testing Instructions
I added a new fixture.
Testing Instructions for Keyboard
Screenshots or screencast