We should escape this because translations might include not supported characters (like quotes or brackets…). Or just move the whole context into a $context variable and use wp_json_encode( $context ) instead.

That makes sense 🙂 I added the esc_attr__ function. I hope that is enough. If you feel it is clearer, I'm happy to mode it to a $context variable.

I think that one turns things like " into ", and it needs to be \". But I'm not an expert on this, so maybe I'm wrong. Can you check if JSON.parse() turns the escaped items (like " or >) back to its original form?

Oh, you're right. esc_attr__ doesn't seem to be working fine. If I include a quote " inside the string, it is not able to parse it and it throws an error. I believe we have two options:

• Use wp_slash or directly addslashes.
• Move it to a variable and use wp_json_encode as you suggested. We are using it in the query block: link.

I've tested both approaches and they seem to work. Any preference?

wp_json_encode seems more explicit and secure 🙂

Thanks for taking a look at this, @SantosGuillamot. I can see in the video you shared that the problem arises when the data-wp-context directive runs in PHP.

What I don't fully understand is that it seems to be an issue serializing the context as JSON (instead of parsing)... 🤔

I looked at the HTML when using it in the navigation block.

In the client

• Without the JSON_HEX_APOS, the HTML is data-wp-context="{"text":"I" m="" a="" string"}'="".
• With JSON_HEX_APOS, the HTML is data-wp-context="{"text":"I\u0027m a string"}".

In the server

• Without the JSON_HEX_APOS, the HTML is data-wp-context='{"text":"I'm a string"}'.
• With JSON_HEX_APOS, the HTML is data-wp-context='{"text":"I\u0027m a string"}'.

So something seems definitely broken, right?

Okay, I've added the flags to both the navigation and the query blocks. Let me know if something else is needed.

For context, the "Fatal error" that can be seen in #54816 (comment) is caused by a problem insidegutenberg_interactivity_process_wp_context implementation, which is calling $context->rewind_context() even when no context where added on a potential failure. That could empty the context stack and make subsequent $context->set_context( $new_context ) calls fail.

I'll open an issue to address that later on.

Fixed here:

• Fix server processing of wp-context getting out of sync #55436