Defer to preceding handlers in command palette keyboard shortcut#53001
Merged
Defer to preceding handlers in command palette keyboard shortcut#53001
Conversation
d68f7d7 to
32e1e0d
Compare
|
Size Change: +7 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for fixing this up! It's testing nicely for me, just left a question about whether it'd be good to use defaultPrevented instead of the isDefaultPrevented function for consistency with the other checks in the repo.
|
Flaky tests detected in a7a5d7cc34f4e9aee9a076590ecd86969e443112. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5707431194
|
a7a5d7c to
8352ef1
Compare
tellthemachines
approved these changes
Jul 31, 2023
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Code LGTM and working as expected.
andrewserong
approved these changes
Jul 31, 2023
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
LGTM, too. Thank you for the updates! ✨
Contributor
Author
|
Thanks for the reviews! |
tellthemachines
pushed a commit
that referenced
this pull request
Aug 1, 2023
Contributor
|
I just cherry-picked this PR to the update/second-round-6-3-rc3 branch to get it included in the next release: 86b95ec |
tellthemachines
added a commit
that referenced
this pull request
Aug 1, 2023
* Top toolbar: Fix issues with save button overlap, and plugin buttons (#53101) * Shorten the width of the top toolbar overlay and make doc title smaller. * Add a scrim and a margin to handle plugin buttons better. * Remove block tools back compat component schedule for deprecated in 6.3 (#53115) * Removes usage of BlockToolsBackCompat * Remove unwanted BlockTools from Nav sidebar * Footnotes/RichText: fix getRichTextValues for deeply nested blocks (#53034) * Defer to preceding handlers in command palette keyboard shortcut (#53001) * Image block: fix image size at wide and full width (#53184) * Fix regression with Edit site Navigate regions (#52940) * Make the navigabel region wrap the inert sidebar. * Adjust animation. * Fix not expanding pattern in page editor (#53169) --------- Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> * Footnotes: fix published preview (#53072) * Footnotes: fix published preview * remove var dump * Fix php lint * PHP lint * Address feedback * Add e2e test * Footnotes: disable for synced patterns and prevent duplication for pages in site editor (#53003) * Initial commit: - Prevent footnote creation withing core/block - Only insert a footnote if one isn't found in the entity block list * Try grabbing controlled blocks from parent post content block * Cache `selectedClientId` Get hasParentCoreBlocks using separate useSelect call. * Rename hasParentCoreBlocks to isBlockWithinPattern Add comments * Removing while loop since we're already fetching the post content parent in the `getBlockParentsByBlockName` call above * Reinstating while loop because it can deal with nested blocks --------- Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> * Footnotes: add missing _ in revision field filter (#53135) * Footnotes: add missing _ in revision field filter * Use correct hook name * Revert prefixing callback names * don't display BlockContextualToolbar at all in contentonly locking (#53110) * Render the footer conditionally in the global styles sidebar component so that any side effects from the footer wrapper are not rendered, e.g., styles and what not (#53204) Ensure that the precise bottom margin persists if the footer isn't rendered * Pattern: Add getBlockRootClientId call (#53206) --------- Co-authored-by: Joen A <1204802+jasmussen@users.noreply.github.com> Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Andrea Fercia <a.fercia@gmail.com> Co-authored-by: Kai Hao <kevin830726@gmail.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Generally what the title says. More specifically this fixes a visual/UX regression that comes along with the command palette’s conflicted keyboard shortcut.
Why?
It’s a visual regression introduced since 6.2. This fixes a symptom of #51737.
How?
If the event has its default behavior prevented then the command palette is not launched.
Testing Instructions
Screenshots or screencast
Before with a flicker
Google.Chrome.-.Home.Template.Part.Editor.My.WordPress.Website.WordPress.2023-06-27.at.11.28.44.AM.mp4