Second round of bugfixes for WP 6.3 RC3#53210
Merged
tellthemachines merged 14 commits intowp/6.3from Aug 1, 2023
Merged
Conversation
…53101) * Shorten the width of the top toolbar overlay and make doc title smaller. * Add a scrim and a margin to handle plugin buttons better.
….3 (#53115) * Removes usage of BlockToolsBackCompat * Remove unwanted BlockTools from Nav sidebar
* Make the navigabel region wrap the inert sidebar. * Adjust animation.
--------- Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
* Footnotes: fix published preview * remove var dump * Fix php lint * PHP lint * Address feedback * Add e2e test
…ges in site editor (#53003) * Initial commit: - Prevent footnote creation withing core/block - Only insert a footnote if one isn't found in the entity block list * Try grabbing controlled blocks from parent post content block * Cache `selectedClientId` Get hasParentCoreBlocks using separate useSelect call. * Rename hasParentCoreBlocks to isBlockWithinPattern Add comments * Removing while loop since we're already fetching the post content parent in the `getBlockParentsByBlockName` call above * Reinstating while loop because it can deal with nested blocks --------- Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
* Footnotes: add missing _ in revision field filter * Use correct hook name * Revert prefixing callback names
…t so that any side effects from the footer wrapper are not rendered, e.g., styles and what not (#53204) Ensure that the precise bottom margin persists if the footer isn't rendered
|
Size Change: +236 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2bc0dad. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5722990149
|
andrewserong
approved these changes
Aug 1, 2023
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
LGTM, gave the changes a quick spot check, and didn't encounter any issues! ✨
Contributor
Author
|
Failure is a known flaky so going to go ahead and merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Merges the following bug fixes to the release branch:
Site editor: conditionally render global styles revisions footer in sidebar
Image block: fix image size at wide and full width
Fix not expanding pattern in page editor
Footnotes: add missing _ in revision field filter
Remove block tools back compat component schedule for deprecated in 6.3
Fix block top toolbar artefact in navigation isolation
Top toolbar: Fix issues with save button overlap, and plugin buttons
Footnotes: fix published preview
Footnotes/RichText: fix getRichTextValues for deeply nested blocks
Footnotes: disable for synced patterns and prevent duplication for pages in site editor
Defer to preceding handlers in command palette keyboard shortcut
Fix regression with Edit site Navigate regions
Pattern: Add getBlockRootClientId call
Patterns: fix color and behavior of unsynced patterns in block inserter when searching for reusable