Revert: Fix/editor content zindex stack context#39620
Merged
mtias merged 2 commits intoWordPress:trunkfrom Mar 22, 2022
Merged
Conversation
Member
|
Thanks for the revert PR! I guess #39331 will have to be reverted along with these changes as well? Would it be possible to bundle that into this PR for ease of testing? |
fec80ed to
945ce7d
Compare
Restores previous `z-index` for editor content area. Reverts b90f46f.
Member
Author
Reverts 2a18443.
This was referenced Mar 21, 2022
ramonjd
approved these changes
Mar 22, 2022
Member
ramonjd
left a comment
There was a problem hiding this comment.
Looks good to me.
Original behaviour is restored for the link and template popovers.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Reverts #38893, "Raise z-index of content div relative to sidebars" (commit b90f46f). This change was introduced to allow the editor's main content area to display link popover modals above the sidebars.
Also reverts a subsequent corrective change in #39331, which was opened due to the original content area
z-indexchange (commit 2a18443).Why?
While #38893 addressed the original issue (#38723), it introduced other downstream issues that rely on the content area appearing at a lower z-axis than the sidebars.
These issues include:
Because of the outsized impact of addressing the original minor issue, there was consensus that the z-axis change should be reverted, and addressed differently. Here are the requests, for reference:
How?
Reversion of the change restores
.interface-interface-skeleton__contenttoz-index: 20. Also rolls back a separate and subsequent adjustment applied for visibility of the Templates "Add New" dropdown menu in #39331.Testing Instructions
Check out PR or apply the patch to
gutenberg:trunkand re-build the plugin. Make sure the plugin is activated.Test 1: Original Issue #38723 (un-fix)
Screenshots
Before Patch
Original fix shows link popover "above" sidebars.
After Patch
Link popover appears "under" sidebars, restoring original behavior.
Regression for #32869
Actions panel retains stacking priority, and popover appears "under" sidebars.
Test 2: Templates "Add New" Dropdown Visibility #39331 (revert)
/wp-admin/site-editor.php).Screenshots
Regression for #39331
"Add New" dropdown menu remains visible.