Templates page: reduce z-index of content area#39331
Merged
Conversation
…over the content.
8 tasks
|
Size Change: +8 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Mar 10, 2022
Contributor
talldan
left a comment
There was a problem hiding this comment.
This fixes it for me. Good catch and quick fix 🎉
Member
Contributor
|
Seems this flow (creating templates) might not be e2e tested. Could be a great new addition to our testing pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR demotes the content area's z-index for
edit-site-list(the Templates list) so that popovers in the header sit over the content.Why?
The z-index of
.interface-interface-skeleton__contentwas bumped to91from20in #38893.The result, for the Templates list page, is that the Add New dropdown sits underneath the content area.
How?
This PR reduces the z-index of
.edit-site-list.interface-interface-skeleton__contentto29.Testing Instructions
/wp-admin/themes.php?page=gutenberg-edit-site&postType=wp_template