[RNMobile] Update react-native-reanimated version to 2.4.1#39430
[RNMobile] Update react-native-reanimated version to 2.4.1#39430
react-native-reanimated version to 2.4.1#39430Conversation
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
| "react-native-modal": "^11.10.0", | ||
| "react-native-prompt-android": "https://raw.githubusercontent.com/wordpress-mobile/react-native-prompt-android/v1.0.0-wp-2/react-native-prompt-android-1.0.0-wp-2.tgz", | ||
| "react-native-reanimated": "https://raw.githubusercontent.com/wordpress-mobile/react-native-reanimated/2.2.4-wp-1/react-native-reanimated-2.2.4-wp-1.tgz", | ||
| "react-native-reanimated": "https://raw.githubusercontent.com/wordpress-mobile/react-native-reanimated/update-version-2.4.1/react-native-reanimated-2.4.1-wp-1.tgz", |
There was a problem hiding this comment.
We have to update the reference once wordpress-mobile/react-native-reanimated#13 is merged and a tag is created.
geriux
left a comment
There was a problem hiding this comment.
LGTM! I tested this on both iOS and Android, the Chrome debugger works for both platforms as well as the Reanimated integration 🚀
|
@geriux I bumped into a building issue when trying to generate the Android installable build in WordPress-Android (reference). I'm working on a fix but it will imply bumping the |
This issue will be fixed in wordpress-mobile/react-native-gesture-handler#18. @geriux I assigned you as a reviewer there, let me know if you will be able to review it, thanks 🙇 . |
Thanks for handling that issue @fluiddot! I've just approved the PR 🙇 |
# Conflicts: # package-lock.json # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
…ress#39430) * Update react-native-reanimated version to 2.4.1 * Update react-native-editor Podfile.lock * Update react-native-reanimated ref with 2.4.1-wp-1 tag * Update react-native-gesture-handler version to 2.2.0-wp-4 * Update package-lock.json * Update package-lock.json
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4653
WordPress-Android PR: wordpress-mobile/WordPress-Android#16106
WordPress-iOS PR: wordpress-mobile/WordPress-iOS#18137
What?
Updates
react-native-reanimated(i.e. Reanimated library) package to version2.4.1.Why?
The current version of Reanimated doesn't allow debugging with the Chrome debugger. However, in newer versions this has been addressed hence, updating the package will allow us to re-enable the Chrome debugger.
How?
A PR has been created in the forked repository of the package, and the version has been bumped in the
package.jsonfile.Testing Instructions
Click here to display the patch diff
NOTE: When the debugger is connected, Reanimated worklets are not executed, so it's expected that the blue ball can't be dragged when debugging.
Screenshots or screencast
N/A