Skip to content

[Gutenberg] Update react-native-reanimated version to 2.4.1#16106

Merged
fluiddot merged 4 commits intogutenberg/after_1.72.0from
gutenberg/update/react-native-reanimated-2.4.1
Mar 18, 2022
Merged

[Gutenberg] Update react-native-reanimated version to 2.4.1#16106
fluiddot merged 4 commits intogutenberg/after_1.72.0from
gutenberg/update/react-native-reanimated-2.4.1

Conversation

@fluiddot
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot commented Mar 15, 2022 •
edited
Loading

This PR only updates one of the GB-mobile dependencies.

To test:
Follow the testing instructions from WordPress/gutenberg#39430.

Regression Notes

  1. Potential unintended areas of impact
    None apart from the editor.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot self-assigned this Mar 15, 2022
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Mar 15, 2022 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@fluiddot
Copy link
Copy Markdown
Contributor Author

fluiddot commented Mar 15, 2022

The installable build failed due to the following error:

java.lang.RuntimeException: 
Duplicate class com.swmansion.common.GestureHandlerStateManager found in modules 
jetified-react-native-gesture-handler-2.2.0-wp-3-runtime (com.github.wordpress-mobile:react-native-gesture-handler:2.2.0-wp-3) and 
jetified-react-native-reanimated-2.4.1-wp-1-runtime (com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1)

Looks like the library react-native-gesture-handler checks if the project already includes Reanimated version 2.3+, and in that case, it prevents duplicating the class. Since we're using a forked repository, this logic has been overlooked and would require publishing a new patch version.

This was referenced Mar 15, 2022
Merged
Merged
Merged
geriux
geriux approved these changes Mar 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is ready to merge as soon as we update the commit with an alpha tag 🚀

@fluiddot fluiddot added this to the 19.6 milestone Mar 18, 2022
@fluiddot fluiddot changed the base branch from trunk to gutenberg/after_1.72.0 March 18, 2022 10:05
@fluiddot fluiddot marked this pull request as ready for review March 18, 2022 10:52
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Mar 18, 2022

You can test the changes on this Pull Request by downloading the APKs:

@fluiddot fluiddot merged commit 4f13fb9 into gutenberg/after_1.72.0 Mar 18, 2022
@fluiddot fluiddot deleted the gutenberg/update/react-native-reanimated-2.4.1 branch March 18, 2022 17:12
@jhnstn jhnstn mentioned this pull request Mar 22, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fluiddot fluiddot

Labels

None yet

Projects

None yet

Milestone

19.6

Development

Successfully merging this pull request may close these issues.

2 participants

@fluiddot @geriux