[RNMobile] Use npm install in React Native e2e tests#35111
Merged
Conversation
ceyhun
approved these changes
Sep 24, 2021
Member
ceyhun
left a comment
There was a problem hiding this comment.
LGTM 👍 React Native E2E Tests (iOS)/(Android) seem to be already failing on trunk, should be good if they pass right now.
Contributor
Author
|
Both React Native E2E tests didn't get the NPM cache and passed 🟢 🎊 : |
This was referenced Sep 28, 2021
fluiddot
added a commit
that referenced
this pull request
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
React Native e2e tests are failing constantly on different branches (including
trunk) when installing dependencies, so we decided to replace the command used fromnpm citonpm installwhich looks like to address the issue. However, I'd like to note that this is a temporary solution, the goal is to address this by the changes from the PR: #34886How has this been tested?
Verify that all PR check passes 🟢 .
Screenshots
N/A
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).