Revert "[RNMobile] Use npm install in React Native e2e tests"#35175
Merged
Revert "[RNMobile] Use npm install in React Native e2e tests"#35175
npm install in React Native e2e tests"#35175Conversation
This reverts commit 4f0a24f.
7 tasks
hypest
reviewed
Sep 28, 2021
Contributor
hypest
left a comment
There was a problem hiding this comment.
Changes look perfect!
I'll hold on for the final "Approve" until CI turns green, just to be sure sure.
Contributor
Author
|
I updated the following CI testing PR #35108 with these changes for double-checking that the dependencies install doesn't fail when the NPM cache is not present. Once the CI checks pass there I'll merge this PR. |
Contributor
Author
CI checks passed 🟢 so I'm going to merge the PR 🎊 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After merging #34886, the workaround introduced in #35111 is no longer required so it would be great if we revert the changes.
How has this been tested?
Verify that "React Native E2E Tests" checks pass.
Screenshots
N/A
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).