Fix: Add Image style settings for hotlinked images#28006
Merged
Conversation
2 tasks
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
geriux
approved these changes
Jan 7, 2021
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! Tested it on both iOS and Android. Thanks for this fix!
guarani
pushed a commit
that referenced
this pull request
Jan 7, 2021
guarani
pushed a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Jan 7, 2021
guarani
pushed a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Jan 7, 2021
guarani
pushed a commit
to wordpress-mobile/WordPress-Android
that referenced
this pull request
Jan 7, 2021
guarani
pushed a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Jan 7, 2021
3 tasks
cameronvoell
pushed a commit
that referenced
this pull request
Jan 11, 2021
* Release script: Update react-native-editor version to 1.44.0 * Release script: Update with changes from 'npm run core preios' * Mobile - Link settings - Fix data not being saved when closing the bottom sheet (#27997) * Set onComplete handler as optional in Range cell component (#27987) Range cell component is used in multiple components but not all of them require the onComplete handler so it should be optional. * Mobile - Link settings - Check for onClose (#28039) * Fix: Add Image style settings for hotlinked images (#28006) * Update CHANGELOG.md (#28042) * Change spaces back to tabs Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> Co-authored-by: Carlos Garcia <fluiddot@gmail.com> Co-authored-by: Enej Bajgoric <enej.bajgoric@automattic.com>
cameronvoell
added a commit
that referenced
this pull request
Jan 18, 2021
* Release script: Update react-native-editor version to 1.44.0 * Release script: Update with changes from 'npm run core preios' * Mobile - Link settings - Fix data not being saved when closing the bottom sheet (#27997) * Set onComplete handler as optional in Range cell component (#27987) Range cell component is used in multiple components but not all of them require the onComplete handler so it should be optional. * Mobile - Link settings - Check for onClose (#28039) * Fix: Add Image style settings for hotlinked images (#28006) * Update CHANGELOG.md (#28042) * Change spaces back to tabs * Release script: Update react-native-editor version to 1.44.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix crash in mobile paragraph blocks with custom font size (#28121) * Remove px suffix from fontSize for Android paragraph * Issue does not seem to be limited to android on latest gutenberg master * Move fontSize char removal to richtext to account for multiple block errors * Add move to top bottom when long pressing block movers (#27554) * WC: Added move to top and bottom functionality via long pressing BlockMover buttons and clicking the button on the BottomSheet Picker. * WIP: Unit tests. * WC: WIP unit tests for add move to top and bottom * WC: Moving UI tests to gutenberg with other UI tests instead of keeping at gutenberg-mobile. Adding more convenience functions to EditorPage. * WIP: Unit tests. * WC: Adding icon and title to picker for move to top/bottom. * WC: Cleaning up code. * WC: Fixing merge issue where import was changed to const. * WC: Changing all imports to requires as per jest bug. * WC: Removing before/afterAll blocks from UI tests. * WC: Removing e2e tests to issue-1191-add-move-to-top-bottom-ui-tests branch. * WC: Updating imports to fall in line with other files. Co-authored-by: Wendy Chen <wendy.chen@automattic.com> * Fixed crash introduced from recent fontSize fix (#28209) * Updated changelog Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> Co-authored-by: Carlos Garcia <fluiddot@gmail.com> Co-authored-by: Enej Bajgoric <enej.bajgoric@automattic.com> Co-authored-by: illusaen <tilphousia@gmail.com> Co-authored-by: Wendy Chen <wendy.chen@automattic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently when the image is hotlinked the Image style settings are not present.
This PR fixes this my making sure that the settings can still be applied.
Before:
(Notice the missing Image styles for the border (default and rounded)
After:
Notice that the image styles are there.
Note: The web editor already support this for hot linked images.
How has this been tested?
Apply this patch.
Open up the iOS Mobile editor in the simulator.
Add a new page for a WordPress.com site using the page templates.
Notice that the images in the image blocks are actually hotlinked and are not imported. So the Image styles are not there. This PR fixes this.
Screenshots
Types of changes
Bug fix, a non breaking change.
Checklist: