Add move to top bottom when long pressing block movers#27554
Merged
cameronvoell merged 12 commits intoWordPress:masterfrom Dec 23, 2020
illusaen:issue-1191-add-move-to-top-bottom
Merged
Add move to top bottom when long pressing block movers#27554cameronvoell merged 12 commits intoWordPress:masterfrom illusaen:issue-1191-add-move-to-top-bottom
cameronvoell merged 12 commits intoWordPress:masterfrom
illusaen:issue-1191-add-move-to-top-bottom
Conversation
Merged
2 tasks
added 7 commits
December 18, 2020 13:49
…kMover buttons and clicking the button on the BottomSheet Picker.
…ng at gutenberg-mobile. Adding more convenience functions to EditorPage.
iamthomasbishop
approved these changes
Dec 18, 2020
iamthomasbishop
left a comment
There was a problem hiding this comment.
The interaction looks great, @illusaen. Nice work!
Regarding casing, per our discussion in slack let's go with sentence-case (per our new guidelines for UI copy). We'll need to do an audit soon across the entire app to find and update title-cased strings, but that will be done separately.
packages/block-editor/src/components/block-mover/index.native.js
Outdated
Show resolved
Hide resolved
cameronvoell
approved these changes
Dec 23, 2020
Member
cameronvoell
left a comment
There was a problem hiding this comment.
New feature is looking good. Nice work here @illusaen !
This was referenced Jan 8, 2021
3 tasks
cameronvoell
pushed a commit
that referenced
this pull request
Jan 14, 2021
* WC: Added move to top and bottom functionality via long pressing BlockMover buttons and clicking the button on the BottomSheet Picker. * WIP: Unit tests. * WC: WIP unit tests for add move to top and bottom * WC: Moving UI tests to gutenberg with other UI tests instead of keeping at gutenberg-mobile. Adding more convenience functions to EditorPage. * WIP: Unit tests. * WC: Adding icon and title to picker for move to top/bottom. * WC: Cleaning up code. * WC: Fixing merge issue where import was changed to const. * WC: Changing all imports to requires as per jest bug. * WC: Removing before/afterAll blocks from UI tests. * WC: Removing e2e tests to issue-1191-add-move-to-top-bottom-ui-tests branch. * WC: Updating imports to fall in line with other files. Co-authored-by: Wendy Chen <wendy.chen@automattic.com>
cameronvoell
added a commit
that referenced
this pull request
Jan 18, 2021
* Release script: Update react-native-editor version to 1.44.0 * Release script: Update with changes from 'npm run core preios' * Mobile - Link settings - Fix data not being saved when closing the bottom sheet (#27997) * Set onComplete handler as optional in Range cell component (#27987) Range cell component is used in multiple components but not all of them require the onComplete handler so it should be optional. * Mobile - Link settings - Check for onClose (#28039) * Fix: Add Image style settings for hotlinked images (#28006) * Update CHANGELOG.md (#28042) * Change spaces back to tabs * Release script: Update react-native-editor version to 1.44.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix crash in mobile paragraph blocks with custom font size (#28121) * Remove px suffix from fontSize for Android paragraph * Issue does not seem to be limited to android on latest gutenberg master * Move fontSize char removal to richtext to account for multiple block errors * Add move to top bottom when long pressing block movers (#27554) * WC: Added move to top and bottom functionality via long pressing BlockMover buttons and clicking the button on the BottomSheet Picker. * WIP: Unit tests. * WC: WIP unit tests for add move to top and bottom * WC: Moving UI tests to gutenberg with other UI tests instead of keeping at gutenberg-mobile. Adding more convenience functions to EditorPage. * WIP: Unit tests. * WC: Adding icon and title to picker for move to top/bottom. * WC: Cleaning up code. * WC: Fixing merge issue where import was changed to const. * WC: Changing all imports to requires as per jest bug. * WC: Removing before/afterAll blocks from UI tests. * WC: Removing e2e tests to issue-1191-add-move-to-top-bottom-ui-tests branch. * WC: Updating imports to fall in line with other files. Co-authored-by: Wendy Chen <wendy.chen@automattic.com> * Fixed crash introduced from recent fontSize fix (#28209) * Updated changelog Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> Co-authored-by: Carlos Garcia <fluiddot@gmail.com> Co-authored-by: Enej Bajgoric <enej.bajgoric@automattic.com> Co-authored-by: illusaen <tilphousia@gmail.com> Co-authored-by: Wendy Chen <wendy.chen@automattic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Original issue link:1191Gutenberg-mobile link:PR 2872Add move to top and move to bottom actions when long pressing block movers.
@iamthomasbishop I have the words in the menu as sentence cased (first word capitalized, rest not); there is a discrepancy in the current app, however, where long pressing the block picker has all words capitalized whereas the gear icon in blocks shows the sentence casing I'm using. I have it is as sentence cased because I think it looks better, but please feel free to inform me if you think that all capitalized looks better.
How has this been tested?
Screenshots
Types of changes
New feature added.
Checklist: