Remove no longer necessary selection checks#22500
Merged
mchowning merged 1 commit intornmobile/release-1.28.1from May 25, 2020
Merged
Remove no longer necessary selection checks#22500mchowning merged 1 commit intornmobile/release-1.28.1from
mchowning merged 1 commit intornmobile/release-1.28.1from
Conversation
mchowning
commented
May 20, 2020
| } | ||
| selection = { | ||
| start: newSelectionStart, | ||
| end: newSelectionEnd, |
Contributor
Author
There was a problem hiding this comment.
Of the three selection checks, this is the only one that tries to do more than just setting the selection to null if there is a problem, so I decided to leave it in even though I think we could probably remove it as well now.
2 tasks
Member
40fb567 to
8f5a873
Compare
|
Size Change: 0 B Total Size: 824 kB ℹ️ View Unchanged
|
These are now handled on the native side
8f5a873 to
948e05e
Compare
Contributor
Author
You're absolutely right @geriux ! I forgot to remove those, but I have now. Thanks! |
geriux
approved these changes
May 21, 2020
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! It's always good to see some code refactor =)
mchowning
added a commit
that referenced
this pull request
May 26, 2020
* RNMobile - Starter Page Templates - Portfolio: adds missing ids for galleries (#22321) * Fix margin for the post-title (#22331) * Fix margin for the post-title Add 4px margin from the edges of the screen and adjust the alignment of text. * Only apply margins on the left and right edges. * Correct buttons appender (#22362) * Remove no longer necessary selection checks (#22500) These are now handled on the native side Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com> Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove checks that are now handled on the native side by Android.
See the related gutenberg-mobile PR for further description and testing steps: wordpress-mobile/gutenberg-mobile#2279
Checklist: