[RNMobile] - Portfolio template - Missing Gallery block ids#22321
Merged
[RNMobile] - Portfolio template - Missing Gallery block ids#22321
Conversation
Merged
2 tasks
|
Size Change: 0 B Total Size: 831 kB ℹ️ View Unchanged
|
pinarol
approved these changes
May 13, 2020
Contributor
pinarol
left a comment
There was a problem hiding this comment.
LGTM!
Both galleries are fixed in the Portfolio layout
SergioEstevao
pushed a commit
that referenced
this pull request
May 13, 2020
mchowning
added a commit
that referenced
this pull request
May 26, 2020
* RNMobile - Starter Page Templates - Portfolio: adds missing ids for galleries (#22321) * Fix margin for the post-title (#22331) * Fix margin for the post-title Add 4px margin from the edges of the screen and adjust the alignment of text. * Only apply margins on the left and right edges. * Correct buttons appender (#22362) * Remove no longer necessary selection checks (#22500) These are now handled on the native side Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com> Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2257Description
Adds missing ids to the galleries to avoid images disappearing when adding new ones.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: