[RNMobile] - Layout Template Modal & Button block - Orientation fixes#21290
Merged
[RNMobile] - Layout Template Modal & Button block - Orientation fixes#21290
Conversation
added 2 commits
March 31, 2020 11:46
…le prop and updates ToolbarButton title
|
Size Change: 0 B Total Size: 866 kB ℹ️ View Unchanged
|
Merged
2 tasks
chipsnyder
approved these changes
Apr 1, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Good work @geriux tested the changes on WPAndroid and validated iOS everything works well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2086Description
It was reported that the Layout template picker was crashing for the
14.5version when the Modal was opened and then changing the orientation of the device (only for Android).The orientation crash was also happening for the Inserter modal but these issues were fixed in this PR to be added in
14.6.Although the previously mentioned PR fixed the modals crash it also introduced some side effects for the
Layout template modaland theButton block.This PR fixes those issues related to orientation changes on Android.
How has this been tested?
Open the WordPress Android app with metro running
Button block test
Layout preview modal test
Screenshots
Types of changes
Bug fix
Checklist: