Layout Template Modal & Button block - Orientation fixes#2086
Merged
Layout Template Modal & Button block - Orientation fixes#2086
Conversation
Merged
6 tasks
Contributor
Author
|
Hey there @lukewalczak @chipsnyder 👋 So we have a crash regarding to modals on Android. I explain more in the Gutenberg PR description. @lukewalczak I made a change in the Button block so I added you as a reviewer just to double check all is good. @chipsnyder would you be able to test as well? not sure how is your PR review queue if not I'll assign someone else 😄 |
Contributor
No problem I can take a look at this tomorrow |
chipsnyder
approved these changes
Apr 1, 2020
This was referenced Apr 13, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2064
Gutenberg PR-> WordPress/gutenberg#21290To test check Gutenberg PR description
PR submission checklist:
RELEASE-NOTES.txtif necessary.