BottomSheet listens to native bridge for closed modals on Android#20860
Merged
cameronvoell merged 6 commits intomasterfrom Mar 25, 2020
Merged
BottomSheet listens to native bridge for closed modals on Android#20860cameronvoell merged 6 commits intomasterfrom
cameronvoell merged 6 commits intomasterfrom
Conversation
|
Size Change: 0 B Total Size: 859 kB ℹ️ View Unchanged
|
4773b72 to
88dbc38
Compare
88dbc38 to
521aff3
Compare
Merged
2 tasks
1 task
mkevins
approved these changes
Mar 17, 2020
Contributor
mkevins
left a comment
There was a problem hiding this comment.
Tested via steps here and it's working as described. Nice work Cameron! 👍
I only left a minor comment about a variable name, as a nitpick, but not a blocker. 😃
e9cd0da to
8a0b989
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/WordPress-Android#10227
Related PRs:
GB-Mobile: wordpress-mobile/gutenberg-mobile#2011
WordPress-Android: wordpress-mobile/WordPress-Android#10383
Description
When the Gutenberg editor on Android is contained in a
Fragment, there are cases on device orientation change where the native AndroidReactInstanceManagerwill dismiss open Modals (Dialogin Android Native code) in order to avoid a crash.This PR allows our Modal utilizing
BottomSheetcomponent to subscribe to messages from the native Android bridge that notify when a Modal is dismissed from native Android, and we'll perform the necessary React Native state updates accordingly by calling theBottomSheetonClosemethod. Failure to callonClosemethod in this instance results in non functioning buttons for opening modals, because React Native state thinks they are still open, hence this change.How has this been tested?
Tested in WordPress Android app, as well as in the Android/iOS example apps. See steps and screenshot below.
Testing steps (same apply for opening the inserter Modal, or clicking insert Image/Video to Open a modal)
Screenshots
Types of changes
Bug fix
Checklist: