[RNMobile] apply flex to prevent caption overlap in Gallery block#20987
Merged
[RNMobile] apply flex to prevent caption overlap in Gallery block#20987
Conversation
2 tasks
|
Size Change: 0 B Total Size: 857 kB ℹ️ View Unchanged
|
7 tasks
geriux
approved these changes
Mar 18, 2020
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this quick fix! Tested both on iOS and Android and on the demo iOS App.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply flex style to View that hold content of
Galleryon mobile. It prevents gallery caption being covered by other block border and keep proper spacing between blocksPlease also refer to:
Related gutenberg-mobile PR
Related gutenberg-mobile issue
How has this been tested?
GalleryblockScreenshots
Types of changes
Bug fix
Checklist: