[RNMobile] Fix crash once adding Group#19457
Merged
lukewalczak merged 1 commit intornmobile/release-v1.20.0from Jan 10, 2020
Merged
[RNMobile] Fix crash once adding Group#19457lukewalczak merged 1 commit intornmobile/release-v1.20.0from
lukewalczak merged 1 commit intornmobile/release-v1.20.0from
Conversation
2 tasks
Contributor
|
👋 Are we going to merge this one or was this forgotten? |
Contributor
|
BTW, I don't have a strong opinion about whether we should merge this to the release branch or not. So far, the crash was only observable with Group block which is not live yet. However, the fix is on Button component. So, if we are confident with the fix we can merge it to prevent any potential problems. |
Member
Author
|
@pinarol The PR is not approved yet, that's why it's not merged. |
pinarol
approved these changes
Jan 10, 2020
Contributor
pinarol
left a comment
There was a problem hiding this comment.
LGTM! 🎉 Tested with WPiOS by adding a Group block
6 tasks
Tug
added a commit
that referenced
this pull request
Jan 10, 2020
* styling fixes after navigation feature merge (#19455) * Styling fixes to navigation feature * Add netural styles for toolbar * Fix condition for not registered component * Display 'Unsupported' in breadcrumbs for missing components * Refactor after CR * Remove leftovers * [FIX] rich text focus loop (#19240) * check if onBlur event contains text that is different than value * add check if there is a text in native event * Prevent re-selection of RichText when native selection changes as a result of resigning focus * Fix typo * Check if isSelected only in onSelectionChangeFromAztec Co-authored-by: Jorge Bernal <jbernal@gmail.com> * [RNMobile] Correct displaying photo during upload (#19502) * [RNMobile] Fix crash once adding Group (#19457) * Add extra branch for travis to run tests onto Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Jorge Bernal <jbernal@gmail.com>
This was referenced Jan 10, 2020
2 tasks
Tug
added a commit
that referenced
this pull request
Jan 14, 2020
…9569) * [RNMobile] Merge mobile release v1.20.0 back into master (#19562) * styling fixes after navigation feature merge (#19455) * Styling fixes to navigation feature * Add netural styles for toolbar * Fix condition for not registered component * Display 'Unsupported' in breadcrumbs for missing components * Refactor after CR * Remove leftovers * [FIX] rich text focus loop (#19240) * check if onBlur event contains text that is different than value * add check if there is a text in native event * Prevent re-selection of RichText when native selection changes as a result of resigning focus * Fix typo * Check if isSelected only in onSelectionChangeFromAztec Co-authored-by: Jorge Bernal <jbernal@gmail.com> * [RNMobile] Correct displaying photo during upload (#19502) * [RNMobile] Fix crash once adding Group (#19457) * Add extra branch for travis to run tests onto Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Jorge Bernal <jbernal@gmail.com> * Revert travis changes Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Jorge Bernal <jbernal@gmail.com>
hypest
added a commit
that referenced
this pull request
Feb 11, 2020
* [RNMobile] Merge mobile release v1.20.0 back into master (#19562) * styling fixes after navigation feature merge (#19455) * Styling fixes to navigation feature * Add netural styles for toolbar * Fix condition for not registered component * Display 'Unsupported' in breadcrumbs for missing components * Refactor after CR * Remove leftovers * [FIX] rich text focus loop (#19240) * check if onBlur event contains text that is different than value * add check if there is a text in native event * Prevent re-selection of RichText when native selection changes as a result of resigning focus * Fix typo * Check if isSelected only in onSelectionChangeFromAztec Co-authored-by: Jorge Bernal <jbernal@gmail.com> * [RNMobile] Correct displaying photo during upload (#19502) * [RNMobile] Fix crash once adding Group (#19457) * Add extra branch for travis to run tests onto Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Jorge Bernal <jbernal@gmail.com> * Adding empty function to RichText children call. (#19818) This fixes a crash originated on this PR: #19536 ` * Disable gallery image size options on mobile (#19828) * [Mobile] Fix blank image size labels on mobile (#19800) (#20045) * Fix blank image size labels on mobile * Use name instead of label in default imageSizes * [RNMobile] Enable Dismiss on PlainText in Android (#20095) * Add flag for determining if running on Android * Enable Dismiss button on PlainText. Enable show keyboard in Android on PlainText mount * Enable Dismiss button on PlainText. Enable show keyboard in Android on PlainText mount Co-authored-by: Tugdual de Kerviler <dekervit@gmail.com> Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Jorge Bernal <jbernal@gmail.com> Co-authored-by: etoledom <etoledom@icloud.com> Co-authored-by: Matthew Kevins <mkevins@users.noreply.github.com> Co-authored-by: Chip <chip.snyder3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a crash once adding a
Groupblock.Ref to gutenberg mobile: wordpress-mobile/gutenberg-mobile#1755
How has this been tested?
GroupblockScreenshots
Types of changes
Check if
iconexists before passing intocloneElement.Checklist: