[RNMobile] Merge mobile release v1.20.0 back into master (step 2)#19569
Merged
[RNMobile] Merge mobile release v1.20.0 back into master (step 2)#19569
Conversation
* styling fixes after navigation feature merge (#19455) * Styling fixes to navigation feature * Add netural styles for toolbar * Fix condition for not registered component * Display 'Unsupported' in breadcrumbs for missing components * Refactor after CR * Remove leftovers * [FIX] rich text focus loop (#19240) * check if onBlur event contains text that is different than value * add check if there is a text in native event * Prevent re-selection of RichText when native selection changes as a result of resigning focus * Fix typo * Check if isSelected only in onSelectionChangeFromAztec Co-authored-by: Jorge Bernal <jbernal@gmail.com> * [RNMobile] Correct displaying photo during upload (#19502) * [RNMobile] Fix crash once adding Group (#19457) * Add extra branch for travis to run tests onto Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Jorge Bernal <jbernal@gmail.com>
39d095c to
ad46ef2
Compare
mchowning
approved these changes
Jan 14, 2020
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Tested on both Android and iOS and everything looks good. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is step 2 in our merge process of gutenberg-mobile v1.20.0 into master. The first one is accepted #19562. This one should be fixing conflicts with master.
Related PR in gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1752
Details:
How has this been tested?
This should be tested in this gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1752 and in the WP apps directly (WPAndroid - wordpress-mobile/WordPress-Android#11052, WPiOS - wordpress-mobile/WordPress-iOS#13190).
Checklist: