Bugfix for wrong isObjectActive flag#17750
Merged
Merged
Conversation
Right now isObjectActive is set as true for every existed replacement. Thats why any custom replacements has PopoverAtImage
Member
|
@struna Thanks for the contribution! I set the merge base to |
Right now isObjectActive is set as true for every existed replacement. Thats why any custom replacements has PopoverAtImage
Contributor
Author
ellatrix
approved these changes
Oct 9, 2019
gziolo
pushed a commit
that referenced
this pull request
Oct 15, 2019
* Bump plugin version to 6.6.0-rc.1 * Typewriter: use DOMRect.top to fix for Edge (#17707) * Bump plugin version to 6.6.0 * Bugfix for wrong isObjectActive flag Right now isObjectActive is set as true for every existed replacement. Thats why any custom replacements has PopoverAtImage * Bugfix for wrong isObjectActive flag Right now isObjectActive is set as true for every existed replacement. Thats why any custom replacements has PopoverAtImage
Member
|
@struna I've tried to reach out via other channels, but I have been unsuccessful in getting in touch. I wanted to make sure you saw the request to you for consent to re-license your contributions to Gutenberg under GPLv2 and MPLv2 here: #31893. If you would kindly review that description and comment accordingly it would be greatly appreciated. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now isObjectActive is set as true for every existed replacement.
Thats why any custom replacements has PopoverAtImage
https://screencast.com/t/CCTMsaRcDMMF