Skip to content

Typewriter: use DOMRect.top to fix for Edge#17707

Merged
youknowriad merged 1 commit into
masterfrom
fix/typewriter-edge
Oct 2, 2019
Merged

Typewriter: use DOMRect.top to fix for Edge#17707
youknowriad merged 1 commit into
masterfrom
fix/typewriter-edge

Conversation

@ellatrix

@ellatrix ellatrix commented Oct 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Fixes #17255. The problem is that Edge does not support the y property on DOMRect. Instead, we can use top.

How has this been tested?

See #17255.

Screenshots

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added Browser Issues Issues or PRs that are related to browser specific problems [Package] Block editor /packages/block-editor labels Oct 2, 2019
@ellatrix ellatrix added this to the Gutenberg 6.6 milestone Oct 2, 2019
youknowriad
youknowriad approved these changes Oct 2, 2019
View reviewed changes

@youknowriad youknowriad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@youknowriad youknowriad merged commit 023cad3 into master Oct 2, 2019
@youknowriad youknowriad deleted the fix/typewriter-edge branch October 2, 2019 12:47
@ellatrix

ellatrix commented Oct 2, 2019

Copy link
Copy Markdown
Member Author

Thanks!

youknowriad pushed a commit that referenced this pull request Oct 2, 2019
@ellatrix @youknowriad
Typewriter: use DOMRect.top to fix for Edge (#17707)
eb2c2a3
@kwight

kwight commented Oct 2, 2019 •
edited
Loading

Copy link
Copy Markdown

The 6.6 final release is on horizon.wordpress.com now and, using a VirtualBox Edge install, I'm seeing a client crash and a console error unable to get property of 'nativeEvent' on undefined or null value – not sure if this is related (and VB is molasses at the best of times 🙃). Just curious if anyone has seen this in native Edge testing.

@ellatrix

ellatrix commented Oct 2, 2019

Copy link
Copy Markdown
Member Author

Are you sure it’s caused by this PR?

@kwight

kwight commented Oct 2, 2019

Copy link
Copy Markdown

No, not sure at all; just surfacing as it's Edge-related (and my testing by VB is less than reliable). I'll do a new issue 👍 .

@kwight kwight mentioned this pull request Oct 2, 2019
Closed
@gwwar

gwwar commented Oct 2, 2019

Copy link
Copy Markdown
Contributor

@ellatrix I tested on IE 11/Windows 10 in BrowserStack. Verified that we don't see a window jump + no nativeEvent errors in console.

Edge in a VM will of course hard crash on a complex app if folks try inspecting things too hard :D

ellatrix pushed a commit that referenced this pull request Oct 9, 2019
@struna @ellatrix
Bugfix for wrong isObjectActive flag (#17750)
b149683 
* Bump plugin version to 6.6.0-rc.1

* Typewriter: use DOMRect.top to fix for Edge (#17707)

* Bump plugin version to 6.6.0

* Bugfix for wrong isObjectActive flag

Right now isObjectActive is set as true for every existed replacement.
Thats why any custom replacements has PopoverAtImage

* Bugfix for wrong isObjectActive flag

Right now isObjectActive is set as true for every existed replacement.
Thats why any custom replacements has PopoverAtImage
gziolo pushed a commit that referenced this pull request Oct 15, 2019
@struna @gziolo
Bugfix for wrong isObjectActive flag (#17750)
102cffe 
* Bump plugin version to 6.6.0-rc.1

* Typewriter: use DOMRect.top to fix for Edge (#17707)

* Bump plugin version to 6.6.0

* Bugfix for wrong isObjectActive flag

Right now isObjectActive is set as true for every existed replacement.
Thats why any custom replacements has PopoverAtImage

* Bugfix for wrong isObjectActive flag

Right now isObjectActive is set as true for every existed replacement.
Thats why any custom replacements has PopoverAtImage
@youknowriad youknowriad mentioned this pull request Nov 19, 2019
Closed
youknowriad pushed a commit that referenced this pull request Dec 5, 2019
@ellatrix @youknowriad
Typewriter: use DOMRect.top to fix for Edge (#17707)
488b779
@youknowriad youknowriad mentioned this pull request Dec 5, 2019
Merged
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Dec 9, 2019
@SergeyBiryukov
Block Editor: Bug fixes targeted for WordPress 5.3.1.
2e175ca 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.

git-svn-id: https://develop.svn.wordpress.org/trunk@46860 602fd350-edb4-49c9-b593-d223f7449a82
nylen pushed a commit to nylen/wordpress-develop-svn that referenced this pull request Dec 9, 2019
Block Editor: Bug fixes targeted for WordPress 5.3.1.
5c7ad47 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.

git-svn-id: https://develop.svn.wordpress.org/trunk@46860 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Dec 9, 2019
@SergeyBiryukov
Block Editor: Bug fixes targeted for WordPress 5.3.1.
a227c23 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.
Built from https://develop.svn.wordpress.org/trunk@46860


git-svn-id: http://core.svn.wordpress.org/trunk@46660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this pull request Dec 9, 2019
@SergeyBiryukov
Block Editor: Bug fixes targeted for WordPress 5.3.1.
35a21dd 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.
Built from https://develop.svn.wordpress.org/trunk@46860


git-svn-id: https://core.svn.wordpress.org/trunk@46660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Dec 9, 2019
@SergeyBiryukov
Block Editor: Bug fixes targeted for WordPress 5.3.1.
499e4b3 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Merges [46860] to the 5.3 branch.
Fixes #48884.

git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46861 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Dec 9, 2019
@SergeyBiryukov
Block Editor: Bug fixes targeted for WordPress 5.3.1.
44bff0d 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Merges [46860] to the 5.3 branch.
Fixes #48884.
Built from https://develop.svn.wordpress.org/branches/5.3@46861


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this pull request Dec 9, 2019
@SergeyBiryukov
Block Editor: Bug fixes targeted for WordPress 5.3.1.
fb11e7c 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Merges [46860] to the 5.3 branch.
Fixes #48884.
Built from https://develop.svn.wordpress.org/branches/5.3@46861


git-svn-id: https://core.svn.wordpress.org/branches/5.3@46661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
sikc8000 pushed a commit to sikc8000/u0_a165-localhost that referenced this pull request Feb 20, 2020
Block Editor: Bug fixes targeted for WordPress 5.3.1.
21a459f 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.
Built from https://develop.svn.wordpress.org/trunk@46860
sikc8000 pushed a commit to sikc8000/u0_a165-localhost that referenced this pull request Feb 20, 2020
Block Editor: Bug fixes targeted for WordPress 5.3.1.
66f7297 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Merges [46860] to the 5.3 branch.
Fixes #48884.
Built from https://develop.svn.wordpress.org/branches/5.3@46861
miya0001 pushed a commit to cjk4wp/wordpress that referenced this pull request Feb 20, 2020
Block Editor: Bug fixes targeted for WordPress 5.3.1.
b294a87 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.

git-svn-id: http://develop.svn.wordpress.org/trunk@46860 602fd350-edb4-49c9-b593-d223f7449a82
VenusPR pushed a commit to VenusPR/Wordpress_Richard that referenced this pull request Mar 9, 2023
@devsyncer
Block Editor: Bug fixes targeted for WordPress 5.3.1.
6df7e9d 
The list of included fixes:

- Edge scrolling issues WordPress/gutenberg#17707
- Intermittent JavaScript issues WordPress/gutenberg#18559
- Remove embed CollegeHumor WordPress/gutenberg#18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Merges [46860] to the 5.3 branch.
Fixes #48884.
Built from https://develop.svn.wordpress.org/branches/5.3@46861


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad approved these changes
@talldan talldan Awaiting requested review from talldan

Assignees

No one assigned

Labels

Browser Issues Issues or PRs that are related to browser specific problems [Package] Block editor /packages/block-editor

Projects

None yet

Milestone

Gutenberg 6.6

Development

Successfully merging this pull request may close these issues.

View jumps to top of window when editing in Microsoft Edge

4 participants

@ellatrix @kwight @gwwar @youknowriad