Add mention of on Figma to CONTRIBUTING.md#16140
Merged
Conversation
enriquesanchez
approved these changes
Jun 13, 2019
Contributor
enriquesanchez
left a comment
There was a problem hiding this comment.
Looks good to me 👍
sarahmonster
approved these changes
Jun 13, 2019
Member
sarahmonster
left a comment
There was a problem hiding this comment.
Works by me! I've left a comment but it's all quite minor, so I'd say we can go ahead and ship this as is.
We might want to update this once our Figma libraries are a bit more fleshed out to include all the different libraries, but since they're still in flux pointing to the main one is a good start and sufficient for now.
CONTRIBUTING.md
Outdated
| ## How Can Designers Contribute? | ||
|
|
||
| If you'd like to contribute to the design or front-end, feel free to contribute to tickets labelled [Needs Design](https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+is%3Aopen+label%3A%22Needs+Design%22) or [Needs Design Feedback](https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+is%3Aopen+label%3A"Needs+Design+Feedback%22). We could use your thoughtful replies, mockups, animatics, sketches, doodles. Proposed changes are best done as minimal and specific iterations on the work that precedes it so we can compare. If you use <a href="https://www.sketchapp.com/">Sketch</a>, you can grab <a href="https://cloudup.com/cMPXM8Va2cy">the source file for the mockups</a> (updated April 6th). | ||
| If you'd like to contribute to the design or front-end, feel free to contribute to tickets labelled [Needs Design](https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+is%3Aopen+label%3A%22Needs+Design%22) or [Needs Design Feedback](https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+is%3Aopen+label%3A"Needs+Design+Feedback%22). We could use your thoughtful replies, mockups, animatics, sketches, doodles. Proposed changes are best done as minimal and specific iterations on the work that precedes it so we can compare. The [WordPress.org Design team](http://make.wordpress.org/design/) uses [Figma](https://www.figma.com/). If you'd like to contribute, consider [joining the The WordPress.org Figma team](https://make.wordpress.org/design/2018/11/19/figma-for-wordpress/). The Figma team has access to a helpful [library of components](https://www.figma.com/file/ZtN5xslEVYgzU7Dd5CxgGZwq/WordPress-Components?node-id=0%3A1) used in WordPress. |
Member
There was a problem hiding this comment.
A few small suggested changes here:
- "WordPress.org Design team" → "WordPress design team"
- "uses Figma" → "uses Figma to more easily collaborate and share work" (or similar)
- "consider joining The WordPress.org Figma team" → "ping in Slack and the design team will set you up with a free Figma account" (the process is a bit different and basically you need to ping an admin)
Contributor
Author
There was a problem hiding this comment.
Thanks @sarahmonster! Updated in 5ad4184.
Member
There was a problem hiding this comment.
💯 that reads a million times better. 🙌 🚢
daniloercoli
added a commit
that referenced
this pull request
Jun 14, 2019
…rnmobile/open-video-by-browser-for-android * 'master' of https://github.com/WordPress/gutenberg: (34 commits) [RNMobile] Native mobile release v1.7.0 (#16156) Scripts: Document and simplify changing file entry and output of build scripts (#15982) Block library: Refactor Heading block to use class names for text align (#16035) Make calendar block resilient against editor module not being present (#16161) Bump plugin version to 5.9.1 Editor: Fix the issue where statics for deprecated components were not hoisted (#16152) Build Tooling: Use "full" `npm install` for Build Artifacts Travis task (#16166) Scripts: Fix naming conventions for function containing CLI keyword (#16091) Add native support for Inserter (Ported from gutenberg-mobile) (#16114) docs(components/higher-order/with-spoken-messages): fix issue in example code (#16144) docs(components/with-focus-return): fix typo in README.md (#16143) docs(block-editor/components/inspector-controls): fix image path in README.md (#16145) Add mention of on Figma to CONTRIBUTING.md (#16140) Bring greater consistency to placeholder text for media blocks. (#16135) Add descriptive text and a link to embed documentation in embed blocks (#16101) Update toolbar-text.png (#16102) Updating changelogs for the Gutenberg 5.9 packages release chore(release): publish [RNMobile] Fix pasting text on Post Title (#16116) Bump plugin version to 5.9.0 ... # Conflicts: # packages/block-library/src/video/video-player.android.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "How Can Designers Contribute?" section of
CONTRIBUTING.mdmentions an outdated Sketch file. Since the design team has largely switched to Figma, we should replace this outdated file with details on our team's Figma resources.