Skip to content

Scripts: Fix naming conventions for function containing CLI keyword#16091

Merged
gziolo merged 1 commit intomasterfrom
update/scripts-function-names
Jun 14, 2019
Merged

Scripts: Fix naming conventions for function containing CLI keyword#16091
gziolo merged 1 commit intomasterfrom
update/scripts-function-names

Conversation

@gziolo
Copy link
Copy Markdown
Member

@gziolo gziolo commented Jun 11, 2019

Description

Addressed the issue found by @aduth in #16079 (comment):

This function is technically not named correctly in accordance with naming guidelines. It should be hasFileInCLIArgs ("CLI" is an acronym).

Function names which this PR updates:

  • getCliArg -> getArgFromCLI
  • getCliArgs -> getArgsFromCLI
  • hasCliArg -> hasArgInCLI
  • hasFileInCliArgs -> hasFileArgInCLI

@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality [Tool] WP Scripts /packages/scripts labels Jun 11, 2019
@gziolo gziolo self-assigned this Jun 11, 2019
@gziolo gziolo requested a review from a team June 13, 2019 14:25
Copy link
Copy Markdown
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gziolo gziolo merged commit 09f67ea into master Jun 14, 2019
@github-actions github-actions bot added this to the Gutenberg 5.10 milestone Jun 14, 2019
@gziolo gziolo modified the milestones: Gutenberg 5.10, Gutenberg 6.0 Jun 14, 2019
@gziolo gziolo deleted the update/scripts-function-names branch June 14, 2019 05:54
daniloercoli added a commit that referenced this pull request Jun 14, 2019
…rnmobile/open-video-by-browser-for-android

* 'master' of https://github.com/WordPress/gutenberg: (34 commits)
  [RNMobile] Native mobile release v1.7.0 (#16156)
  Scripts: Document and simplify changing file entry and output of build scripts (#15982)
  Block library: Refactor Heading block to use class names for text align (#16035)
  Make calendar block resilient against editor module not being present (#16161)
  Bump plugin version to 5.9.1
  Editor: Fix the issue where statics for deprecated components were not hoisted (#16152)
  Build Tooling: Use "full" `npm install` for Build Artifacts Travis task (#16166)
  Scripts: Fix naming conventions for function containing CLI keyword (#16091)
  Add native support for Inserter (Ported from gutenberg-mobile) (#16114)
  docs(components/higher-order/with-spoken-messages): fix issue in example code (#16144)
  docs(components/with-focus-return): fix typo in README.md (#16143)
  docs(block-editor/components/inspector-controls): fix image path in README.md (#16145)
  Add mention of on Figma to CONTRIBUTING.md (#16140)
  Bring greater consistency to placeholder text for media blocks. (#16135)
  Add descriptive text and a link to embed documentation in embed blocks (#16101)
  Update toolbar-text.png (#16102)
  Updating changelogs for the Gutenberg 5.9 packages release
  chore(release): publish
  [RNMobile] Fix pasting text on Post Title (#16116)
  Bump plugin version to 5.9.0
  ...

# Conflicts:
#	packages/block-library/src/video/video-player.android.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Tool] WP Scripts /packages/scripts [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants