Skip to content

Add wpDataSelect WordPress end 2 end test util#15052

Merged
jorgefilipecosta merged 2 commits intomasterfrom
add/wpDataSelect-end-2-end-test-util
Apr 19, 2019
Merged

Add wpDataSelect WordPress end 2 end test util#15052
jorgefilipecosta merged 2 commits intomasterfrom
add/wpDataSelect-end-2-end-test-util

Conversation

@jorgefilipecosta
Copy link
Copy Markdown
Member

Description

This a follow up on a suggestion by @gziolo to have a simple utility that allows us to easily query the WordPress data module.

How has this been tested?

Verify the end 2 end tests pass.

@jorgefilipecosta jorgefilipecosta added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Apr 18, 2019
Copy link
Copy Markdown
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like this util a lot. In fact, we might also want to deprecate all the existing wrappers which seem to be no longer necessary and bring only another level of abstraction 🤷‍♂️

@aduth and @youknowriad, what do you think about that?

@jorgefilipecosta jorgefilipecosta force-pushed the add/wpDataSelect-end-2-end-test-util branch from f3d06e8 to cf90445 Compare April 19, 2019 14:40
@jorgefilipecosta jorgefilipecosta merged commit d8ed3d6 into master Apr 19, 2019
@jorgefilipecosta jorgefilipecosta deleted the add/wpDataSelect-end-2-end-test-util branch April 19, 2019 15:54
daniloercoli added a commit that referenced this pull request Apr 23, 2019
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor

* 'master' of https://github.com/WordPress/gutenberg:
  'string' misspelled as 'srting' (#15118)
  [Mobile] Improving accessibility on Post title (#15106)
  Fix 13776: Format is already registered to handle class name (#15072)
  Add wpDataSelect WordPress end 2 end test util (#15052)
  Block Editor: move selection state from RichText to the store (#14640)
  chore: Fix: Lint error that makes unit tests (and CI tests) fail. (#15073)
  Set ownProps.onFocus when context.onFocus is undefined. (#15069)
@youknowriad youknowriad added this to the 5.6 (Gutenberg) milestone May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants