Block Editor: move selection state from RichText to the store#14640
Merged
Block Editor: move selection state from RichText to the store#14640
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11616.
Blocks #11005 and #12002. Blocks making RichText a controlled component.
This is an attempt to move local
RichTextselection state toblock-editorstore.RichTextwould have the following props:selectionStart: the selection start offset, similar to thetextareaattrubute.selectionEnd: the selection end offset, similar to thetextareaattrubute.onSelectionChange: the function that will be called when the selection changes.Within blocks, this state is provided by context. Nothing changes for block authors.
In the
block-editorstore, the selection state will now include a rich text identifier and offset in addition to the block client ID.Why?
How has this been tested?
Screenshots
Types of changes
Checklist: