Skip to content

Test transform from media to embed blocks#13997

Merged
gziolo merged 3 commits intomasterfrom
add/tests-for-transform-embeddable-urls
Apr 18, 2019
Merged

Test transform from media to embed blocks#13997
gziolo merged 3 commits intomasterfrom
add/tests-for-transform-embeddable-urls

Conversation

@draganescu
Copy link
Copy Markdown
Contributor

@draganescu draganescu commented Feb 21, 2019

Closes #11901

Added e2e tests to test the transform of audio, video and image blocks in to embeds when embeddable URLs are provided

Description

Added e2e tests to test the transform of audio, video and image blocks in to embeds when embeddable URLs are provided

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@draganescu draganescu added [Type] Task Issues or PRs that have been broken down into an individual action to take [Block] Embed Affects the Embed Block labels Feb 21, 2019
@draganescu draganescu added this to the 5.2 (Gutenberg) milestone Feb 21, 2019
@draganescu draganescu self-assigned this Feb 21, 2019
@draganescu draganescu mentioned this pull request Feb 21, 2019
Closed
aduth
aduth reviewed Feb 21, 2019
View reviewed changes
@aduth aduth requested review from aduth and notnownikki February 21, 2019 20:49
@draganescu
Copy link
Copy Markdown
Contributor Author

draganescu commented Feb 22, 2019

I added the mocking of audio and image test URLs and also used the video URL which was already mocked.

@gziolo gziolo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Feb 25, 2019
@draganescu draganescu force-pushed the add/tests-for-transform-embeddable-urls branch from 088083c to ad23c70 Compare February 25, 2019 09:35
@draganescu
Copy link
Copy Markdown
Contributor Author

draganescu commented Feb 25, 2019 •
edited
Loading

The undo tests seem to fail for everyone on travis, for some they work on local.

Ran locally they fail because of a timeout. Interestingly, setting the timeout to be higher using both jest.setTimeout( 100000 ); and PUPPETEER_TIMEOUT=10000 has no effect.

Running in playback mode results in the same timeout, although visual inspection shows undo does work!

@aduth
Copy link
Copy Markdown
Member

aduth commented Feb 26, 2019

Yes, the Undo tests are very unstable at the moment. I'm hoping this is improved with #14108.

noisysocks
noisysocks requested changes Mar 5, 2019
View reviewed changes
@youknowriad youknowriad removed this from the 5.3 (Gutenberg) milestone Mar 18, 2019
@draganescu draganescu force-pushed the add/tests-for-transform-embeddable-urls branch from ad23c70 to 2cce5c2 Compare March 29, 2019 13:48
@draganescu
Copy link
Copy Markdown
Contributor Author

draganescu commented Mar 29, 2019

rebased and changed @noisysocks requested changes

@draganescu draganescu requested a review from noisysocks March 29, 2019 14:23
@noisysocks
Copy link
Copy Markdown
Member

noisysocks commented Mar 31, 2019

Looks like Travis might be reporting a legitimate test failure:

FAIL specs/embedding.test.js (62.532s)
  ● Embedding content › should transform from audio to embed block when Soundcloud URL is pasted
    waiting for selector ".wp-block-embed-soundcloud" failed: timeout 30000ms exceeded
      271 | 		await page.keyboard.type( 'https://soundcloud.com/a-boogie-wit-da-hoodie/swervin' );
      272 | 		await page.keyboard.press( 'Enter' );
    > 273 | 		await page.waitForSelector( '.wp-block-embed-soundcloud' );
          | 		           ^
      274 | 	} );
      275 | } );
      276 | 
      at new WaitTask (../../node_modules/puppeteer/lib/FrameManager.js:840:28)
      at Frame._waitForSelectorOrXPath (../../node_modules/puppeteer/lib/FrameManager.js:731:12)
      at Frame.waitForSelector (../../node_modules/puppeteer/lib/FrameManager.js:690:17)
      at Page.waitForSelector (../../node_modules/puppeteer/lib/Page.js:1008:29)
      at Object.waitForSelector (specs/embedding.test.js:273:14)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/embedding.test.js:9:103)
      at _next (specs/embedding.test.js:11:194)

@draganescu
Copy link
Copy Markdown
Contributor Author

draganescu commented Apr 10, 2019

@noisysocks @youknowriad this now passes all checks.

gziolo
gziolo approved these changes Apr 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I trust Travis it works :)

@gziolo gziolo merged commit ea6cdb4 into master Apr 18, 2019
@gziolo gziolo deleted the add/tests-for-transform-embeddable-urls branch April 18, 2019 06:33
@gziolo gziolo added this to the 5.6 (Gutenberg) milestone Apr 18, 2019
daniloercoli added a commit that referenced this pull request Apr 18, 2019
@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
7b08aa3 
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor

* 'master' of https://github.com/WordPress/gutenberg:
  Reset embed mocks on every request, stop request to instagram (#15046)
  Refactor core blocks to have save and transforms in their own files (part 2) (#14899)
  Fix pullquote import (#15036)
  Refactor core blocks to have save and transforms in their own files (part 4) (#14903)
  Refactor core blocks to have save and transforms in their own files (part 3) (#14902)
  Refactor core blocks to have deprecated extracted to their ownf files (p.1) (#14979)
  Test transform from media to embed blocks (#13997)
  If a more recent revision/autosave exists, store its state on editor setup (#7945)
  chore(release): publish
This was referenced Apr 29, 2019
Merged
Merged
This was referenced Sep 12, 2024
Open
Open
Open
@AKJUS AKJUS mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noisysocks noisysocks noisysocks approved these changes

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

@notnownikki notnownikki Awaiting requested review from notnownikki

@aduth aduth Awaiting requested review from aduth

Assignees

@draganescu draganescu

Labels

[Block] Embed Affects the Embed Block [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Milestone

5.6 (Gutenberg)

Development

Successfully merging this pull request may close these issues.

Add Tests: Transform embeddable URLs in Audio/Video/Image to Embed Block

5 participants

@draganescu @aduth @noisysocks @gziolo @youknowriad